Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Voucher:' before voucher code on edit cart page #13059

Open
drummer83 opened this issue Jan 3, 2025 · 2 comments · May be fixed by #13061
Open

Add 'Voucher:' before voucher code on edit cart page #13059

drummer83 opened this issue Jan 3, 2025 · 2 comments · May be fixed by #13061
Assignees
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.

Comments

@drummer83
Copy link
Contributor

Description

Follow up of #12998.

We have a 'Voucher:' prefix before the voucher code in most places where the voucher amount is displayed. However, this prefix is missing on the edit cart page.

See testing notes for some screenshots.

Expected Behavior

We should have the same prefix in all places.

Actual Behaviour

We don't have the 'Voucher:' prefix on the edit cart page.

Steps to Reproduce

  1. Set up an order including a voucher.
  2. Proceed to checkout using that voucher until order summary page, but don't complete the order.
  3. Go to the edit cart page (/cart).
  4. Look at the voucher code.

Animated Gif/Screenshot

What it looks like:
grafik

What it should look like:
grafik

Workaround

Severity

bug-s4: it's annoying, but you can use it

Your Environment

  • Version used:
  • Browser name and version:
  • Operating System and version (desktop or mobile):

Possible Fix

@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Jan 3, 2025
@drummer83 drummer83 added the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label Jan 3, 2025
@github-project-automation github-project-automation bot moved this to To triage (By the maintainers) in Welcome New Developers! Jan 3, 2025
@drummer83 drummer83 moved this from To triage (By the maintainers) to Frontend Easy in Welcome New Developers! Jan 3, 2025
@kernal053
Copy link
Contributor

Do we need to add spec for this too in spec/views/spree/orders/edit.html.haml_spec.rb ?

@drummer83
Copy link
Contributor Author

Thanks @kernal053,
Yes, I think that would be great!

@kernal053 kernal053 linked a pull request Jan 4, 2025 that will close this issue
4 tasks
@sigmundpetersen sigmundpetersen moved this from All the things 💤 to In Progress ⚙ in OFN Delivery board Jan 6, 2025
@sigmundpetersen sigmundpetersen moved this from Frontend Easy to In progress in Welcome New Developers! Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.
Projects
Status: In Progress ⚙
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants