[Reports] Bulk co-op reports showing products from cancelled orders

[audez]

Description

Cancelled orders appear in:

• Bulk Co-op Packing Sheets
• Bulk Co-op Customer Payments
• Bulk Co-op Allocation

Expected Behavior

Orders shouldn't appear in bulk co-op reports if they are cancelled.

Steps to Reproduce

1. Create a bulk product (product with the "group by" option activated
2. Create an OC with this product and pass an order
3. Cancel the order
4. Open the bulk co-op reports and see the order appear in these reports

Animated Gif/Screenshot

This order has been cancelled

But still appear in 3 bulk co-op reports

Severity

bug-s3: a feature is broken but there is a workaround

[RachL]

@lin-d-hop to add on the reports tweaks?

[jibees]

I read the spec, and noticed that showing canceled orders is wanted:

openfoodnetwork/spec/lib/reports/bulk_coop_report_spec.rb

Lines 34 to 40 in 046d7d5

	it 'shows canceled orders' do
	o2 = create(:order, state: 'canceled', completed_at: 1.day.ago, order_cycle: oc1,
	distributor: d1)
	line_item = build(:line_item_with_shipment)
	o2.line_items << line_item
	expect(subject.table_items).to include(line_item)
	end

openfoodnetwork/spec/lib/reports/bulk_coop_report_spec.rb

Lines 52 to 58 in 046d7d5

	it 'shows canceled orders' do
	o2 = create(:order, state: 'canceled', completed_at: 1.day.ago, order_cycle: oc1,
	distributor: d1)
	line_item = build(:line_item_with_shipment)
	o2.line_items << line_item
	expect(subject.table_items).to include(line_item)
	end

Before changing anything, I just want to be sure that we don't want to show canceled orders (and to be sure that changing that won't introduce any regression ; maybe we should add a checkbox Show canceled orders?)

[audez]

Thanks for this input! Just 2 comments: it seems weird to want to show canceled orders here whereas they don't appear in the "classic" packing reports. Also, if we show the canceled orders in Allocation and Packing Sheets, it will display the wrong quantities to prepare.

[lin-d-hop]

We don't want to show Cancelled orders in the Bulk Coop reports.

@jibees This should be delivered under the 'Standardise Bulk Coop Reports' epic meaning that it should be released as new reports (see here).

This is in the epic acceptance criteria but not in the bug report. Apologies for that confusion!