Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Search functionality - Backend #91

Merged
merged 33 commits into from
Oct 4, 2022
Merged

feat: Search functionality - Backend #91

merged 33 commits into from
Oct 4, 2022

Conversation

aadarsh-ram
Copy link
Collaborator

@aadarsh-ram aadarsh-ram commented Sep 23, 2022 •
edited
Loading

What

  • Search functionality in backend

Related Issue(s)

@aadarsh-ram aadarsh-ram marked this pull request as ready for review September 24, 2022 13:56
@aadarsh-ram aadarsh-ram requested a review from a team as a code owner September 24, 2022 13:56
alexgarel
alexgarel requested changes Sep 27, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are on a good way !
Great work.

backend/editor/entries.py Outdated Show resolved Hide resolved
parser/openfoodfacts_taxonomy_parser/parser.py Show resolved Hide resolved
parser/requirements-test.txt Outdated Show resolved Hide resolved
parser/setup.cfg Outdated Show resolved Hide resolved
parser/openfoodfacts_taxonomy_parser/parser.py Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
alexgarel
alexgarel requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some comments.

backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/normalizer.py Show resolved Hide resolved
alexgarel
alexgarel approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
alexgarel
alexgarel reviewed Oct 4, 2022
View reviewed changes
parser/openfoodfacts_taxonomy_parser/parser.py
query = """
CREATE FULLTEXT INDEX nodeSearchIds FOR (n:ENTRY) ON EACH [n.id]
OPTIONS {indexConfig: {`fulltext.analyzer`: 'keyword'}}
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

alexgarel
alexgarel approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @aadarsh-ram 🎉

@alexgarel alexgarel merged commit 3317fae into main Oct 4, 2022
@alexgarel alexgarel deleted the search-backend branch October 4, 2022 12:20
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@aadarsh-ram aadarsh-ram

Labels
None yet
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aadarsh-ram @alexgarel