Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix export to local file #352

Merged
merged 6 commits into from
Jan 19, 2024
Merged

fix: fix export to local file #352

merged 6 commits into from
Jan 19, 2024

Conversation

eric-nguyen-cs
Copy link
Contributor

What

  • Fixes export to local file
  • Refactors parser code to decrease future developer errors from happening

Fixes bug(s)

#351

@eric-nguyen-cs eric-nguyen-cs requested a review from a team as a code owner January 18, 2024 11:50
perierc
perierc requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@perierc perierc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think there is 1 problem

backend/editor/entries.py Outdated Show resolved Hide resolved
parser/openfoodfacts_taxonomy_parser/utils.py Outdated Show resolved Hide resolved
@eric-nguyen-cs eric-nguyen-cs merged commit b18ac03 into main Jan 19, 2024
7 checks passed
@eric-nguyen-cs eric-nguyen-cs deleted the ericn/fix-export-error branch January 19, 2024 10:27
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perierc perierc perierc approved these changes

Assignees

@eric-nguyen-cs eric-nguyen-cs

Labels
backend parser tests
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-nguyen-cs @perierc