-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require a custom user agent to use the SDK #44
Comments
@teolemon - what exactly is the misuse? Who do you reach out to on a useragent like e.g. "PHP-SDK - Crawler"? |
Would't it be better to create personalized (organizational or independent) API keys? |
@teolemon this package is already doing this:
|
No. Currently, the user-agent value is populated with the name of the app the developer is using the package within. On default laravel installation this is "Laravel". As a fallback the value is set instead "Laravel Open Food Facts - https://github.com/openfoodfacts/openfoodfacts-laravel". However in practice, that latter shouldn't ever happen since the APP_NAME environment variabele is - as far as I am aware - always available and set in Laravel app's.
No, but it won't happen anyhow. See previous answer. |
|
It's not Laravel SDK specific, we're getting many search queries (and other) that don't make any sense for human usage, and it would be cool to have an idea of who is using the API. |
for the SDK's in general we could maybe introduce some kind of custom headers, like X-OFF-SDK (e.g. having a value of Laravel, Android, Ruby, whatever) along with X-OFF-SDK-VERSION to specify the SDK version no. |
What
IN the same way, we don't want to implement an API key mechanism and all that kind of stuff.
The text was updated successfully, but these errors were encountered: