Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image upload is not properly credited to the contributor #3520

Closed
Tracked by #4202
, #4164 ,  #4465
...
teolemon opened this issue Sep 11, 2020 · 5 comments · Fixed by #4575
Closed
Tracked by #4202
, #4164 ,  #4465
...

Image upload is not properly credited to the contributor #3520

teolemon opened this issue Sep 11, 2020 · 5 comments · Fixed by #4575
Labels
bug Produces incorrect or unexpected result or behaviour. contribution Currently in production help wanted image upload Issues relating to image upload in products P0 quality of contributions

Comments

@teolemon
Copy link
Member

teolemon commented Sep 11, 2020 •
edited
Loading

What

Image upload is not properly credited to the contributor

Screenshot

image

Part of
@teolemon teolemon added bug Produces incorrect or unexpected result or behaviour. contribution image upload Issues relating to image upload in products quality of contributions labels Sep 12, 2020
@VaiTon
Copy link
Member

VaiTon commented Oct 29, 2020

What do you mean? Is newt a user?

Does this happens always or just sometimes?

@teolemon teolemon mentioned this issue Aug 29, 2021
Open
4 tasks
@teolemon
Copy link
Member Author

This happens all the time, for logged in users. I'm able to reproduce by using the Image manager to crop images. This openfoodfacts-contributors is actually me, from my mobile phone, with latest develop
https://world.openfoodfacts.org/product/3528161506805/buche-glacee
image

@teolemon teolemon mentioned this issue Jan 23, 2022
Open
17 tasks
@teolemon teolemon added the P0 label Jan 23, 2022
@teolemon teolemon mentioned this issue Feb 6, 2022
Open
7 tasks
@teolemon teolemon moved this to Todo in Android app Feb 19, 2022
@teolemon
Copy link
Member Author

@VaiTon did you have a chance to start investigations ? Did you find anything ?

@teolemon
Copy link
Member Author

https://github.com/openfoodfacts/openfoodfacts-androidapp/blob/develop/app/src/main/java/openfoodfacts/github/scrachx/openfood/models/entities/SendProduct.java#L51

@g123k
Copy link
Contributor

g123k commented Mar 21, 2022

Well actually it seems that sometimes the app doesn't provide a password.
A fix is coming

@g123k g123k mentioned this issue Mar 21, 2022
Merged
Repository owner moved this from Todo to Done in Android app Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Produces incorrect or unexpected result or behaviour. contribution Currently in production help wanted image upload Issues relating to image upload in products P0 quality of contributions
Projects
Android app
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: In some cases, the user password is not sent to the API g123k/openfoodfacts-androidapp
3 participants
@g123k @teolemon @VaiTon