Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scanned products that do not exist in Open Food Facts do not appear in history #168

Closed
teolemon opened this issue Oct 9, 2016 · 6 comments
Closed

Scanned products that do not exist in Open Food Facts do not appear in history #168

teolemon opened this issue Oct 9, 2016 · 6 comments
Labels
bug Produces incorrect or unexpected result or behaviour. enhancement hacktoberfest help wanted history The use and exporting of history within the application scanning
Milestone
Scan & Search His...

Comments

@teolemon
Copy link
Member

teolemon commented Oct 9, 2016

Scanned products that do not exist in Open Food Facts do not appear in history.
Perhaps keep them, but with a "Product Unknown" placeholder.
@teolemon teolemon modified the milestone: Scan & Search History Nov 20, 2016
@teolemon teolemon added the history The use and exporting of history within the application label Jan 20, 2018
@Karljoones
Copy link
Member

We could work this so when the user tries to open an "unknown" product that it brings them to the activity that they would see should they decide to add it at the time of scan

@SulbhaAgg
Copy link

can I work on this issue?

@teolemon teolemon added the bug Produces incorrect or unexpected result or behaviour. label Sep 25, 2018
@teolemon
Copy link
Member Author

@N00845855 if you're still up for it, please do 🙂

@SulbhaAgg
Copy link

mission started

@rsi2m
Copy link

rsi2m commented Oct 1, 2020

@teolemon @Karljoones Is this problem still relevant? If yes, then I could fix it as part of #hacktoberfest

@teolemon
Copy link
Member Author

teolemon commented Oct 1, 2020

It seems fixed if you decide to add a product.
You can pick some other issue

@teolemon teolemon closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Produces incorrect or unexpected result or behaviour. enhancement hacktoberfest help wanted history The use and exporting of history within the application scanning
Projects
None yet
Milestone
Scan & Search History
Development

No branches or pull requests
4 participants
@rsi2m @teolemon @Karljoones @SulbhaAgg