Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import "flash." ? #57

Closed
madneon opened this issue Jan 28, 2017 · 2 comments · Fixed by #58
Closed

Import "flash." ? #57

madneon opened this issue Jan 28, 2017 · 2 comments · Fixed by #58

Comments

@madneon
Copy link

madneon commented Jan 28, 2017

Sources use import flash.[...], shouldn't it be import openfl.[...] already? Can I create pull request for this?
@jgranick
Copy link
Member

By importing flash.*, I believe this library will work with the Haxe/Flash target directly, without the use of OpenFL, or will work in OpenFL, too.

However, this may not be important, and that it's hosted officially by OpenFL, we could consider this change (and then standard Flash users could add a --remap openfl:flash if desired)

@askmeaboutlo0m
Copy link
Contributor

+1 this actually causes compilation to fail for me, telling me that I can't access the package flash when inside a macro. Replacing all occurrences with openfl makes it work correctly.

@askmeaboutlo0m askmeaboutlo0m mentioned this issue Mar 3, 2017
Merged
@ddavout ddavout mentioned this issue Mar 24, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use openfl instead of flash packages
3 participants
@jgranick @madneon @askmeaboutlo0m