feat: support custom path in apiTokenIssuer #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
|
Thanks @marcoquotech! Instead of accepting this, would you mind keeping this in tandem with the support we have in other SDKs. You can reference this ticket for the details: openfga/sdk-generator#238 Change the
We would also like to see tests to ensure that this is working as expected, see the tests in the Go SDK for example: https://github.com/openfga/go-sdk/blob/main/api_open_fga_test.go#L277-L319 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the refreshAccessToken method to conditionally append the /oauth/token endpoint to the apiTokenIssuer only when the apiTokenIssuer does not include its own path. This ensures that the URL is correctly formed whether the issuer contains a custom path or is just a domain.
References
Closes #141
Review Checklist