This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
deps: update jsonrpc-core #9780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-pleasereview 🤓
seunlanlege
approved these changes
Oct 19, 2018
ordian
force-pushed
the
update-jsonrpc-core
branch
from
627f89d
to
a490db0
Compare
|
I don't think we should merge it into master, since it conflicts with #9657. Just wanted to see if it works on Windows before we backport this. |
|
@ordian parity-tech/jsonrpc#master has the new |
niklasad1
added
the
A3-inprogress ⏳
|
@seunlanlege yes, I know that. In order to incorporate recent changes in jsonrpc-core, we can either update jsonrpc-core#parity-0.11 in stable and beta, or backport #9657. The latter is huge, so I'm in favor of the first approach. |
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes recent changes by @seunlanlege, cc #9102