-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
Only clear the nonce cache when a block is retracted
This reverts commit b382c19.
Fat fingers. |
PollFilter::Logs(.., ref filter) => Some(filter.clone()), | ||
_ => None, | ||
})) { | ||
Some(filter) => filter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentionally changed the behaviour here, returning empty vector when querying e.g. pendingTransactionFilter
for logs was weird. I think "Filter not found" is more appropriate response.
Why is this on ice? |
Oh, nice! 😆 |
Yeah, sorry about that. I labelled the before after I realised that Andre closed it. I'm done with it now, so it can be left open. As for the context of the PR:
The pending transactions filter doesn't require such pending set though, we are ok with unordered hashes and we don't need to be super sure about the nonce, so this PR:
Thanks to this it works really fast (just constructs the |
Please assign reviewers yourself. I'm confused about the authorship of this PR :) |
And make pending transaction count display on ethstats again!