Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

EIP-100 #4954

Closed
wants to merge 5 commits into from
Closed

EIP-100 #4954

wants to merge 5 commits into from

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 18, 2017

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 18, 2017
@arkpar
Copy link
Collaborator

arkpar commented Mar 21, 2017

As far as I can see this implements EIP-100a. EIP-100b looks simpler and this is what go-ethereum implements.

@debris
Copy link
Collaborator Author

debris commented Mar 21, 2017

done

@arkpar
Copy link
Collaborator

arkpar commented Mar 22, 2017

For eip100b you don't really need to read and pass around uncle count. You can just check if uncles_root is empty or not in the header.

@arkpar arkpar added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 22, 2017
@debris
Copy link
Collaborator Author

debris commented Mar 22, 2017

you are absolutely right! I will close this one and create a new pr ;)

@debris debris closed this Mar 22, 2017
@5chdn 5chdn deleted the eip100 branch January 3, 2018 19:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debris @arkpar