This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
move daemonize before creating account provider #10003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-pleasereview 🤓
andresilva
reviewed
Nov 30, 2018
5chdn
added
A8-looksgood 🦄
This was referenced Nov 30, 2018
seunlanlege
approved these changes
Nov 30, 2018
5chdn
pushed a commit
that referenced
this pull request
Nov 30, 2018
* move daemonize before creating account provider * daemonize: add a future-proofing comment
5chdn
pushed a commit
that referenced
this pull request
Nov 30, 2018
* move daemonize before creating account provider * daemonize: add a future-proofing comment
5chdn
added a commit
that referenced
this pull request
Nov 30, 2018
* version: bump stable to 2.1.8 * Fix Bloom migration (#9992) * Fix wrong block number in blooms migration * Fix wrong `const` type (usize -> u64) 😬 * Fix daemonize (#10000) * Revert "prevent silent errors in daemon mode, closes #9367 (#9946)" This reverts commit 52d5278. * deps(daemonize): switch back to crates.io * move daemonize before creating account provider (#10003) * move daemonize before creating account provider * daemonize: add a future-proofing comment
5chdn
added a commit
that referenced
this pull request
Nov 30, 2018
* version: bump beta to 2.2.3 * Fix Bloom migration (#9992) * Fix wrong block number in blooms migration * Fix wrong `const` type (usize -> u64) 😬 * Fix daemonize (#10000) * Revert "prevent silent errors in daemon mode, closes #9367 (#9946)" This reverts commit 52d5278. * deps(daemonize): switch back to crates.io * move daemonize before creating account provider (#10003) * move daemonize before creating account provider * daemonize: add a future-proofing comment
niklasad1
pushed a commit
that referenced
this pull request
Dec 16, 2018
* move daemonize before creating account provider * daemonize: add a future-proofing comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #10000, thanks @andresilva for spotting the issue.
The fetch service didn't work in #10000, since daemonize closed its open fds. We could've moved
daemonizeat the beginning, but we're trying to print as much errors (cf. #9367) as possible before starting a daemon.