-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Make tests pass on nightly again #9953
Comments
For short term I can put jemalloc as default allocator with crate jemallocator, I currently need to fork heapsize with very few changes:
I do not believe it will be a good long term solution (I do not really like the idea to get specific allocator things). Maybe running more approximate allocation evalution (without querying the allocator). |
The good long term solution is to kill the heapsize crate. |
This is our window to address it:
Ideally, we have a fix before Christmas |
We certainly want to continue using jemalloc on supported platforms. It is much faster than the system allocator. |
@arkpar that should not be a problem (I intend to allow setting global allocator on a PR I am currently working on). Regarding the 10024 PR I believe the test limit does not matter that much and this change should be fine. (being able to switch to the default allocator might prove being useful in the future). |
closed by #10432 (heapsize part) |
I guess the problem is that rust nightly no longer uses jemalloc and we're using
heapsize
crate, which assumes it does (cc rust-lang/rust/issues/56069). A temporary solution would be to use jemalloc as a global allocator (https://github.com/alexcrichton/jemallocator ?).The text was updated successfully, but these errors were encountered: