Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Android test builds do not compile #9721

Closed
5chdn opened this issue Oct 9, 2018 · 5 comments
Closed

Android test builds do not compile #9721

5chdn opened this issue Oct 9, 2018 · 5 comments
Labels
F4-tests 💻 Tests need fixing, improving or augmenting. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Milestone

Comments

@5chdn
Copy link
Contributor

5chdn commented Oct 9, 2018

  • Parity Ethereum version: 2.1.2
  • Operating system: Android
  • Installation: built from source
  • Fully synchronized: no
  • Network: ethereum
  • Restarted: yes

Android builds do not compile

    Checking tokio-retry v0.1.1
    Checking tokio-named-pipes v0.1.0 (https://github.com/nikvolf/tokio-named-pipes#0b9b728e)
    Checking tokio-uds v0.1.7
error[E0425]: cannot find function `get_peer_cred` in module `ucred`
   --> .cargo/registry/src/github.com-1ecc6299db9ec823/tokio-uds-0.1.7/src/lib.rs:310:16
    |
310 |         ucred::get_peer_cred(self)
    |                ^^^^^^^^^^^^^ not found in `ucred`

   Compiling ring v0.12.1 (https://github.com/paritytech/ring#bae475e9)
    Checking env_logger v0.5.13
error: aborting due to previous error

For more information about this error, try `rustc --explain E0425`.
error: Could not compile `tokio-uds`.
warning: build failed, waiting for other jobs to finish...
error: build failed
Command exited with non-zero status 101
301.83user 30.22system 3:04.98elapsed 179%CPU (0avgtext+0avgdata 383416maxresident)k
0inputs+1444384outputs (8443major+5272898minor)pagefaults 0swaps
ERROR: Job failed: exit code 1
@5chdn 5chdn added F4-tests 💻 Tests need fixing, improving or augmenting. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. M4-core ⛓ Core client code / Rust. labels Oct 9, 2018
@5chdn 5chdn added this to the 2.2 milestone Oct 9, 2018
@5chdn
Copy link
Contributor Author

5chdn commented Oct 9, 2018

@5chdn 5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018
@niklasad1
Copy link
Collaborator

Fixed by #9657

@gabreal gabreal reopened this Oct 31, 2018
@gabreal
Copy link
Contributor

gabreal commented Oct 31, 2018

error[E0463]: can't find crate for proc_macro
--> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-0.4.20/src/lib.rs:53:1
|
53 | extern crate proc_macro;
| ^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

I'm still seeing this error on android builds (https://gitlab.parity.io/gabriel/parity-ethereum/-/jobs/106947). Is this related or shall I open an other issue?

@niklasad1
Copy link
Collaborator

@gabreal

Android actually builds fine but the test build fails and this seems related to proc_macro. If you change the title of the issue then it's fine to keep it. But, still I think it's a bit overkill to run the tests on android for now

citing @tomaka

According to dtolnay/proc-macro-hack#6 you shouldn't put extern crate proc_macro; in any dependency. The build will fail on some platforms only, and that seems to include Android for example

@gabreal gabreal changed the title Android builds do not compile Android test builds do not compile Nov 1, 2018
@5chdn 5chdn modified the milestones: 2.3, 2.4 Jan 10, 2019
@5chdn 5chdn modified the milestones: 2.4, 2.5 Feb 21, 2019
@soc1c soc1c modified the milestones: 2.5, 2.6 Apr 2, 2019
@ordian ordian modified the milestones: 2.6, 2.7 Jul 12, 2019
@adria0
Copy link

adria0 commented Jul 27, 2020

Closing issue due to its stale state.

@adria0 adria0 closed this as completed Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F4-tests 💻 Tests need fixing, improving or augmenting. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Development

No branches or pull requests

6 participants