Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Refactor: alleviate painful AsHashDB impls with macro (or magic) #9022

Closed
dvdplm opened this issue Jul 2, 2018 · 1 comment
Closed

Refactor: alleviate painful AsHashDB impls with macro (or magic) #9022

dvdplm opened this issue Jul 2, 2018 · 1 comment
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Milestone
2.7

Comments

@dvdplm
Copy link
Collaborator

dvdplm commented Jul 2, 2018

In the course of Make HashDB generic changes were made to the HashDB trait that made it impossible to keep the generic impls of AsHashDB we had before. To work around this concrete impls for AsHashDB were added in many places. Find a more elegant way to deal with the issue, e.g. by adding a impl_as_hash_db! macro.

See the NOTE in the code for more details.
@dvdplm dvdplm added F6-refactor 📚 Code needs refactoring. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. M4-core ⛓ Core client code / Rust. labels Jul 2, 2018
@dvdplm dvdplm mentioned this issue Jul 2, 2018
Merged
@5chdn 5chdn added this to the 1.13 milestone Jul 2, 2018
@5chdn 5chdn modified the milestones: 2.1, 2.2 Jul 17, 2018
@5chdn 5chdn added this to the 2.3 milestone Sep 27, 2018
@5chdn 5chdn modified the milestones: 2.3, 2.4 Oct 29, 2018
@5chdn 5chdn modified the milestones: 2.4, 2.5 Jan 10, 2019
@5chdn 5chdn modified the milestones: 2.5, 2.6 Feb 21, 2019
@soc1c soc1c modified the milestones: 2.6, 2.7 Apr 2, 2019
@adria0
Copy link

adria0 commented Jul 27, 2020

Closing the issue due to its stale state

@adria0 adria0 closed this as completed Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Milestone
2.7
Development

No branches or pull requests
4 participants
@dvdplm @adria0 @5chdn @soc1c