Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Move common crates to parity-common #9011

Closed
8 tasks done
dvdplm opened this issue Jun 29, 2018 · 4 comments
Closed
8 tasks done

Move common crates to parity-common #9011

dvdplm opened this issue Jun 29, 2018 · 4 comments
Assignees
Labels
F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies. P5-sometimesoon 🌲 Issue is worth doing soon. Q5-substantial 📓 Can be fixed by a developer with decent experience.
Milestone

Comments

@dvdplm
Copy link
Collaborator

dvdplm commented Jun 29, 2018

To enable more ergonomic use and easier maintenance of crates in parity-ethereum in other projects, move common crates to a new parity-common repo and publish the subcrates to crates.io.

As a first approximation "common crates" are crates used both in parity-ethereum and Polkadot and that are not ethcore.

This work will be on-going and this here ticket is mostly about defining the basic premises and creating infrastructure.

@dvdplm dvdplm added P5-sometimesoon 🌲 Issue is worth doing soon. Q5-substantial 📓 Can be fixed by a developer with decent experience. M4-core ⛓ Core client code / Rust. M0-build 🏗 Building and build system. M1-ci 🙉 Continuous integration. M3-docs 📑 Documentation. M5-dependencies 🖇 Dependencies. F5-task 🎬 Generic label for things that just have to get done but are no issues in first place. labels Jun 29, 2018
@dvdplm dvdplm self-assigned this Jun 29, 2018
@dvdplm
Copy link
Collaborator Author

dvdplm commented Jun 29, 2018

cc @5chdn @gavofyork @folsen looks about right to you?

@5chdn 5chdn added this to the 1.13 milestone Jun 29, 2018
@5chdn 5chdn added F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. and removed F5-task 🎬 Generic label for things that just have to get done but are no issues in first place. M0-build 🏗 Building and build system. M1-ci 🙉 Continuous integration. M3-docs 📑 Documentation. labels Jun 29, 2018
@5chdn
Copy link
Contributor

5chdn commented Jun 29, 2018

is ethcore-* only used by parity ethereum?

@dvdplm
Copy link
Collaborator Author

dvdplm commented Jun 29, 2018

Yes, at least I believe so. I think the sentiment when discussing this was that the ethcore crate is so big and somewhat unstructured that moving it (or any of the parts) would be a big undertaking. We'd risk ending up with all of parity-ethereum in parity-common.

(Note that there's at least one ethcore-* that is not part of the ethcore crate: ethcore-bytes. That one we can and will move.)

@5chdn
Copy link
Contributor

5chdn commented Jun 29, 2018

if we move anything from ethcore-* to parity-common, please rename it to parity-*

Because once in common, it's not ethereum specific anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies. P5-sometimesoon 🌲 Issue is worth doing soon. Q5-substantial 📓 Can be fixed by a developer with decent experience.
Projects
None yet
Development

No branches or pull requests

2 participants