Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

impl error::Error for ethcore::Error #8239

Closed
debris opened this issue Mar 28, 2018 · 2 comments
Closed

impl error::Error for ethcore::Error #8239

debris opened this issue Mar 28, 2018 · 2 comments
Labels
M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Milestone
2.0 Ethereum

Comments

@debris
Copy link
Collaborator

debris commented Mar 28, 2018

Could be also done by moving ethcore::Error to error_chain

#8150 (diff)
@debris debris added Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. labels Mar 28, 2018
@5chdn 5chdn added this to the 1.11 milestone Mar 28, 2018
@ascjones ascjones mentioned this issue Apr 12, 2018
Merged
@5chdn 5chdn modified the milestones: 1.11, 1.12 Apr 24, 2018
@dvdplm
Copy link
Collaborator

dvdplm commented May 3, 2018

@ascjones can this be closed (in light of #8386)?

@debris
Copy link
Collaborator Author

debris commented May 3, 2018

yes, it can!

@debris debris closed this as completed May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Milestone
2.0 Ethereum
Development

No branches or pull requests
3 participants
@dvdplm @debris @5chdn