Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Thread '<unnamed>' panicked at 'overflow converting duration to nanoseconds' #8003

Closed
jennazenk opened this issue Feb 26, 2018 · 3 comments
Closed
Labels
F1-panic 🔨 The client panics and exits without proper error handling. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q9-epic 🌪 Can only be fixed by John Skeet.
Milestone

Comments

@jennazenk
Copy link

jennazenk commented Feb 26, 2018

  • Which Parity version?: v1.9.0-beta-53ec114-20180125/x86_64-macos/rustc1.23.0
  • Which operating system?: MacOS
  • How installed?: via installer
  • Are you fully synchronized?: yes
  • Which network are you connected to?: ethereum
  • Did you try to restart the node?: yes

When running parity --chain foundation, I got the following:

stack backtrace:

Thread '<unnamed>' panicked at 'overflow converting duration to nanoseconds', src/libcore/option.rs:874

Restarting the node fixed it, just letting you guys know!

@5chdn 5chdn added P5-sometimesoon 🌲 Issue is worth doing soon. M4-core ⛓ Core client code / Rust. F1-panic 🔨 The client panics and exits without proper error handling. labels Feb 28, 2018
@5chdn 5chdn modified the milestones: 1.10, 1.11 Feb 28, 2018
@debris
Copy link
Collaborator

debris commented Mar 13, 2018

It's probably quite serious. There are multiple places in our codebase when we create Duration::from_secs and add it to Instant or SystemTime. rust std executes the addition by converting Duration to nanoseconds which may cause unhandled overflows.

@debris debris added the Q9-epic 🌪 Can only be fixed by John Skeet. label Mar 13, 2018
@azulmarino
Copy link

Hit on Parity v1.9.4-20180228 beta

@5chdn 5chdn modified the milestones: 1.11, 1.12 Apr 24, 2018
@folsen
Copy link
Contributor

folsen commented May 21, 2018

The issue was identified to probably come from expontential backoff time additions in auto-updater. There may however be other cases where it's from adding times with different resolutions, see rust-lang/rust#48980

@folsen folsen closed this as completed May 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F1-panic 🔨 The client panics and exits without proper error handling. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q9-epic 🌪 Can only be fixed by John Skeet.
Projects
None yet
Development

No branches or pull requests

5 participants