Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Parity dev chain spec does not support Byzantium #7735

Closed
vincentserpoul opened this issue Jan 30, 2018 · 7 comments · Fixed by #7753
Closed

Parity dev chain spec does not support Byzantium #7735

vincentserpoul opened this issue Jan 30, 2018 · 7 comments · Fixed by #7753
Labels
F2-bug 🐞 The client fails to follow expected behavior. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon.
Milestone

Comments

@vincentserpoul
Copy link
Contributor

vincentserpoul commented Jan 30, 2018

I'm running:

  • Which Parity version?: 1.8.x, 1.9.x.
  • Which operating system?: MacOS & Linux
  • How installed?: docker
  • Are you fully synchronized?: dev
  • Which network are you connected to?: dev
  • Did you try to restart the node?: yes

steps to reproduce
To reproduce: deploy a contract with not enough gas and call getTransactionReceipt on it.
when you call getTransactionReceipt, instead of having status 0x00 or 0x01 according to stackoverflow following byzantium), you get a null status.

actual
transactionReceipt.status: null
expected behavior
transactionReceipt.status: 0x00

@AyushyaChitransh
Copy link

I faced this bug previously and it was corrected by using eip658Transition in genesis file. #6887 reports similar behavior.

@vincentserpoul
Copy link
Contributor Author

should the dev genesis include this?

@AyushyaChitransh
Copy link

I think that dev genesis should also include that to show correct behavior. I run my private network and have to include this in my genesis file to get correct status.

@tomusdrw tomusdrw added F2-bug 🐞 The client fails to follow expected behavior. M4-core ⛓ Core client code / Rust. labels Jan 30, 2018
@tomusdrw
Copy link
Collaborator

tomusdrw commented Jan 30, 2018

Seems like a bug in spec file indeed. Dev chain should include byzantium features.

@tomusdrw tomusdrw changed the title parity dev is returning status: null for getTransactionReceipt Parity dev chain spec does not support Byzantium Jan 30, 2018
@5chdn 5chdn added the P5-sometimesoon 🌲 Issue is worth doing soon. label Jan 31, 2018
@5chdn 5chdn added this to the 1.10 milestone Jan 31, 2018
@5chdn
Copy link
Contributor

5chdn commented Jan 31, 2018

What is this?

https://github.com/paritytech/parity/blob/master/ethcore/res/instant_seal.json#L29

A registrar? It conflicts with the byzantium built-ins.

@tomusdrw
Copy link
Collaborator

@5chdn seems so, although I think registrar address is still missing in the spec file for this to work.

@5chdn
Copy link
Contributor

5chdn commented Jan 31, 2018

ok, I'll give it a try

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F2-bug 🐞 The client fails to follow expected behavior. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants