Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Provide "num_workers" configuration option #10872

Closed
ghost opened this issue Jul 11, 2019 · 2 comments
Closed

Provide "num_workers" configuration option #10872

ghost opened this issue Jul 11, 2019 · 2 comments
Labels
F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone

Comments

@ghost
Copy link

ghost commented Jul 11, 2019

re #10085

num_workers is currently hard-coded to 4
https://github.com/paritytech/parity-ethereum/blob/7c335e87642b848f61ab3ee7bbff5964b53d6f11/util/io/src/service_mio.rs#L198_

A configuration-option should be provided, with a default of 4.

Implementation

Look at the num_verifiers config option as a guideline.

Compatibility

Using a default of 4, the behavior should be the same

@jam10o-new jam10o-new added F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. labels Jul 11, 2019
@jam10o-new jam10o-new added this to the 2.7 milestone Jul 11, 2019
@ghost
Copy link
Author

ghost commented Jul 12, 2019

@joshua-mir , this one is related to #10085 (which is still unsolved, possibly closed by automatism).

Edit: priority should be increased.

@debris
Copy link
Collaborator

debris commented Jul 29, 2019

eventually we want to get rid of util/io so this feature is not a priority

@debris debris closed this as completed Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

2 participants