Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove Travis builds #1792

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Conversation

edalex-ian
Copy link
Member

Checklist
Description of change

We've now migrated to GitHub Actions with good results after running for 1 to 2 months. So as per the CDM decision, let's remove Travis (starting here on develop only - will keep on older stable branches etc).

We've now migrated to GitHub Actions with good results after running for
1 to 2 months.
@edalex-ian edalex-ian requested a review from a team June 5, 2020 00:40
@edalex-ian
Copy link
Member Author

Drats! And GHA then goes to fail with it's unique case I've seen a couple of times.

On uploading the artefacts, it sometimes fails, which means the tests then can't get access to the installer to test against. But for some reason, even when artefact upload fails, the task is marked as successful but you see this in the logs:

Retry limit has been reached for chunk at offset 398458880 to https://pipelines.actions.githubusercontent.com/iRC5GUUXoTDFYBfBPWte0CZHpnFt0VgNRq4iivqbrN4Qg9rcsB/_apis/resources/Containers/2712561?itemPath=Artefacts%2Fartefacts.tar
##[warning]Aborting upload for /home/runner/work/openEQUELLA/openEQUELLA/artefacts.tar due to failure
Total size of all the files uploaded is 398458880 bytes
Finished uploading artifact Artefacts. Reported size is 398458880 bytes. There were 1 items that failed to upload
Artifact upload has finished successfully!

Anyway, I've restarted the build. 😞

If this continues in the future, we can raise an issue against the action - or it seems like it could be actions/upload-artifact#71

@edalex-ian
Copy link
Member Author

Looks okay now, just failed a known flaky test. HierarchyTopicTest.

Probably fine to merge.

Copy link
Contributor

@PenghaiZhang PenghaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also remove travis related files in autotest such as travis.conf and yaml files (e.g. testng-travis-contribution.yaml)

@edalex-ian
Copy link
Member Author

Good point @PenghaiZhang , I'll do that now(ish).

@edalex-ian
Copy link
Member Author

If I get green on GHA and CodeBuild, I'll merge on in.

@edalex-ian edalex-ian requested a review from PenghaiZhang June 10, 2020 06:15
@edalex-ian edalex-ian merged commit 06021e3 into openequella:develop Jun 10, 2020
@edalex-ian edalex-ian deleted the ci/remove-travis branch June 10, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants