libusb-compat improvements (ptest, bugfixes, cleanup) #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert commit ed93794 from oe-core: libusb-compat: move libraries to base_libdir udev links to libusb-compat, and so this library needs to be in base_libdir (/lib) instead of libdir (/usr/lib). The libdir=base_libdir configuration was needed for udev but it's not the case anymore. Remove it to simplify the recipe. Signed-off-by: Yoann Congal <[email protected]> Reviewed-by: Ever ATILANO <[email protected]>
Fixes [YOCTO #15032] by upgrading the source to a commit including the fix : change SONAME detection source from ldd to objdump ldd detects used libraries by partially running the target binary. This is a problem for when the target binary is not runnable (e.g. cross-compilation). Switch to objdump which only reads info from the ELF file without running anything from it. Signed-off-by: Yoann Congal <[email protected]> Reviewed-by: Ever ATILANO <[email protected]>
Build and run example programs as test. This will only catch major errors (.so lib won't load etc.) because no output check is done, only return status is checked. Signed-off-by: Yoann Congal <[email protected]> Reviewed-by: Ever ATILANO <[email protected]>
libusb-compat dlopen() libusb1 so we need to explicitly RDEPENDS on it. Signed-off-by: Yoann Congal <[email protected]> Reviewed-by: Ever ATILANO <[email protected]>
ycongal-smile
force-pushed
the
yco/libusb-compat_v2
branch
from
20665e0 to
0ac065e
Compare
|
(forgot to add the |
|
it has been merged with f50f9a9 |
|
Thanks @kraj ! :) |
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Nov 30, 2023
* Fix-float-endianness-issue-on-big-endian-arch.patch removed because fixed in the new version. Changelog: * Fix baud rate handling with RTU under Linux * Fix modbus_disable_quirks signature * Remove Travis CI * Move content about migration to libmodbus.org * Avoid negative value in FD_SET call * Test socket against positive value instead of -1 * Improvements to autotools by @ndim * Fix doc links by @jordanjohnson56 (openembedded#653) * Test the protocol id for 0 by @metapsychologe (openembedded#509) * Fix double negative in tests * New quirks handler (closes openembedded#38 openembedded#533) * Fix bitwise OR in documentation * Improve doc about slave ID in RTU * Add .clang-format and format code (closes openembedded#394) * Remove constraints on baud rate values * Accept IP or device in arg of unit test progs * Avoid compilation issue with VS2022 with strdup * Display created files in configure.js * Use strcpy_s under Windows * Replace inet_addr by inet_pton calls * Replace inet_ntoa by inet_ptop * Update configure.ac/config.h.win32 for new inet functions * Instructions to build libmodbus in a VS project * Fix connection check for Windows RTU (closes openembedded#660, openembedded#662) * Add CIFuzz Github action by @DavidKorczynski (openembedded#669) * Convert a few int to unsigned int (openembedded#402) * Major rewrite of documentation with Material for mkdocs * Reduce memory use of TCP PI backend (closes openembedded#621) * Fixed MODBUS_ERROR_RECOVERY_LINK not working on Windows (@embeddedmz) * Replace Travis CI by GitHub CI * Fix linker error for Windows (VCLinkerTool) * Address check in single register / coil responses added (openembedded#463) * Swap CRC bytes in request data but not at CRC computing (openembedded#397) * Fix float endianness issue on big endian architecture * Fix comment about EMBUNKEXC (closes openembedded#566) * Fix network library detection on Haiku * Fix typos (closes openembedded#620) Signed-off-by: alperak <[email protected]> Signed-off-by: Khem Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the diverse improvements I made to the
libusb-compatrecipe while working on https://bugzilla.yoctoproject.org/show_bug.cgi?id=15032.