Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react-bootstrap dependency from Card component #2484

Open
2 tasks
viktorrusakov opened this issue Jul 28, 2023 · 0 comments
Open
2 tasks

Remove react-bootstrap dependency from Card component #2484

viktorrusakov opened this issue Jul 28, 2023 · 0 comments
Labels
best addressed by breaking change code health Proactive technical investment via refactorings, removals, etc. engineering Engineering enhancement Relates to new features or improvements to existing features

Comments

@viktorrusakov
Copy link
Contributor

Currently Paragon inherits from react-bootstrap's Card which will become a problem after removing compound components (#2464) because their Card also has a multiple of compound components defined which will get into consuming applications' bundle without a single usage. Furthermore, we have completely customized Card's behaviour by building our own subcomponents, which resulted in not using anything from react-bootstrap besides Card wrapper. It doesn't make much sense anymore to re-use react-bootstrap's Card.

Tasks

@viktorrusakov viktorrusakov added enhancement Relates to new features or improvements to existing features code health Proactive technical investment via refactorings, removals, etc. labels Jul 28, 2023
@viktorrusakov viktorrusakov added the engineering Engineering label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best addressed by breaking change code health Proactive technical investment via refactorings, removals, etc. engineering Engineering enhancement Relates to new features or improvements to existing features
Projects
Status: Backlog
Development

No branches or pull requests

2 participants