Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support CLA checks in merge queues #234

Open
1 task
brian-smith-tcril opened this issue Apr 14, 2023 · 1 comment
Open
1 task

Feature: Support CLA checks in merge queues #234

brian-smith-tcril opened this issue Apr 14, 2023 · 1 comment

Comments

@brian-smith-tcril
Copy link
Contributor

GitHub has added a feature called "merge queues" (docs) that feel like a very good solution to some of the race condition issues with automatic PRs I've encountered on https://github.com/openedx/openedx-translations/

When adding a PR to a merge queue, it will try to get the CLA status, but the hook will never return anything
image

I have added "Merge groups" to the events that trigger openedx-webhooks, but I have not started looking into what changes need to happen in code here to allow running the CLA check for PRs in a queue.

Acceptance Criteria:

  • When a PR is added to a merge queue, the CLA check runs and correctly reports the status.
@nedbat
Copy link
Contributor

nedbat commented Apr 14, 2023

We can debug why the bot gets stuck in this situation. I have no experience with merge queues, so I'm not sure how they affect things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants