Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Proposal: Rename Content model to RawContent #32

Closed
ormsbee opened this issue Feb 16, 2023 · 5 comments
Closed

Refactoring Proposal: Rename Content model to RawContent #32

ormsbee opened this issue Feb 16, 2023 · 5 comments
Assignees
@ormsbee

Comments

@ormsbee
Copy link
Contributor

ormsbee commented Feb 16, 2023 •
edited
Loading

I've come to appreciate that I use the word "Content" all the time in a very general sense, and I don't want to cause confusion about whether I'm talking about a general concept or a specific low level model. RawContent has a more accurate connotation of what it is (pretty much bytes with only the barest MIME type metadata). And it makes join tables not too awkward–ComponentVersionRawContent is understandable, for instance.
@ormsbee
Copy link
Contributor Author

ormsbee commented Feb 16, 2023

FYI @bradenmacdonald, @kdmccormick, @feanil

@kdmccormick
Copy link
Member

I like it 👍🏻

@ormsbee ormsbee self-assigned this Feb 16, 2023
@ormsbee ormsbee changed the title Proposal: Rename Content model to RawContent Refactoring Proposal: Rename Content model to RawContent Feb 16, 2023
@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Feb 17, 2023 •
edited
Loading

Seems reasonable to me. 👍🏻

@feanil
Copy link
Contributor

feanil commented Feb 17, 2023

Makes sense to me as well. 👍🏾

@ormsbee
Copy link
Contributor Author

ormsbee commented Apr 1, 2023

Accepted and closing, as I'm doing this work as part of #33

@ormsbee ormsbee closed this as completed Apr 1, 2023
@ormsbee ormsbee moved this from In Progress to Done in Modular Learning - Tagging and Libraries Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ormsbee ormsbee

Labels
None yet
Projects
Modular Learning - Tagging and Libraries
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ormsbee @feanil @bradenmacdonald @kdmccormick