Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update pagination for reporting configurations #1357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Nov 20, 2024

Description
These changes are to resolve the issue that NUS is facing. Only 10 reports are showing up on the admin portal. This is a temporary solution, I am working on implementing pagination on the Reporting Configuration page.

Issue: https://2u-internal.atlassian.net/browse/ENT-9728

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.57%. Comparing base (0561675) to head (fd4ec4b).

Files with missing lines Patch % Lines
src/data/services/LmsApiService.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1357   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files         600      600           
  Lines       13224    13224           
  Branches     2795     2787    -8     
=======================================
  Hits        11316    11316           
  Misses       1842     1842           
  Partials       66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant