Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: video engagement updates #134

Merged
merged 2 commits into from
Nov 19, 2024
Merged

fix: video engagement updates #134

merged 2 commits into from
Nov 19, 2024

Conversation

saraburns1
Copy link
Contributor

@saraburns1 saraburns1 commented Nov 15, 2024 •
edited
Loading

fix rewatched calculation
make params optional

@saraburns1 saraburns1 closed this Nov 15, 2024
@saraburns1 saraburns1 reopened this Nov 18, 2024
@saraburns1 saraburns1 changed the title fix: fix rewatched query fix: video engagement updates Nov 18, 2024
@Ian2012
Copy link
Contributor

Ian2012 commented Nov 19, 2024

@saraburns1 will you disable the unit tests for now?

Ian2012
Ian2012 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Ian2012 Ian2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm if you are going to remove the unit test, feel free to merge and release

@saraburns1
Copy link
Contributor Author

yes - unit test is already removed, just the seed data for the test is being removed here.

@saraburns1 saraburns1 merged commit 11c44ff into openedx:main Nov 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ian2012 Ian2012 Ian2012 approved these changes

@bmtcril bmtcril Awaiting requested review from bmtcril

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saraburns1 @Ian2012