Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block ordering to models #82

Merged
merged 3 commits into from
May 1, 2024
Merged

Add block ordering to models #82

merged 3 commits into from
May 1, 2024

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Apr 30, 2024

This should allow us to do ordering based on where the block is in the course, and work around the issue of lexical sort on block names when using section:subsection:unit. There will need to be downstream changes in Superset to use it, though.

Copy link
Contributor

@Ian2012 Ian2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should allow us to remove all references to the subsection_name_with_location and section_name_with_location.

Is this going to be worked here too?

@bmtcril
Copy link
Contributor Author

bmtcril commented Apr 30, 2024

@Ian2012 I think we still want those things, we just want them to sort correctly

@bmtcril bmtcril requested a review from SoryRawyer May 1, 2024 00:56
Copy link
Contributor

@SoryRawyer SoryRawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@bmtcril bmtcril merged commit 6681a2e into main May 1, 2024
4 checks passed
@bmtcril bmtcril deleted the bmtcril/block_ordering branch May 1, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants