-
Notifications
You must be signed in to change notification settings - Fork 422
fix: add names to redis and mongo volumes #1153
fix: add names to redis and mongo volumes #1153
Conversation
Thanks for the pull request, @mohd-akram! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Thanks for this PR @mohd-akram! Aside from needing a rebase, are the changes ready for review? |
@itsjeyd Yup, they are. |
Thanks @mohd-akram, I'm lining this up for a test run now. Once the build is green the changes can go to engineering review. CC @jmbowman for arch-bom |
@mohd-akram Looks like we got a green build here, and can proceed with next steps. @jmbowman This PR is ready for engineering review by arch-bom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm unable to rebase this, but it's good as far as I'm concerned. |
Out of curiosity, is there some symptom that this fixes, or is this just to make sure that our docker-compose lists all of the relevant volumes? (Happy to merge either way, once the branch is brought up to date.) |
3d46117
to
5d139da
Compare
Yes. Every time you do |
Ah! I'd wondered what all those anonymous volumes were from when I ran |
@mohd-akram 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
I was able to confirm the fix -- this is a great little improvement. :-) |
@timmc-edx Thanks! |
The [mongo](https://hub.docker.com/_/mongo) and [redis](https://hub.docker.com/_/redis) images provide additional volumes that aren't specified in the compose files. This ensures they have proper names and aren't anonymous. This fix should prevent the accumulation over time of anonymous volumes (long hexadecimal names) that show up in `docker volume ls`.
The mongo and redis images provide additional volumes that aren't specified in the compose files. This ensures they have proper names and aren't anonymous.