feat(migrate): add support for cstor volume migration #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <[email protected]>
mittachaitu
reviewed
Jun 6, 2020
| }, | ||
| } | ||
| if targetDeploy.Spec.Template.Spec.Affinity != nil { | ||
| tempPolicy.Spec.Target.PodAffinity = targetDeploy.Spec.Template.Spec.Affinity.PodAffinity |
There was a problem hiding this comment.
Do we need to handle nodeAffinity also?
cc: @prateekpandey14
mittachaitu
reviewed
Jun 8, 2020
| if pvObj.Spec.PersistentVolumeSource.CSI == nil { | ||
| csiPV := &corev1.PersistentVolume{} | ||
| csiPV.Name = pvObj.Name | ||
| csiPV.Annotations = map[string]string{ |
There was a problem hiding this comment.
If user-configured labels and annotations for some other purpose we will lose them
- adds code to patch skip-validation annotation - improves wait mechanism for validations after migration due to time taking rebuilds - address review comments Signed-off-by: shubham <[email protected]>
|
@mittachaitu Addressed the review comments. Will take label and annotation literal changes as well as snapshot migration in separate PR. |
mittachaitu
reviewed
Jun 9, 2020
mittachaitu
reviewed
Jun 10, 2020
Signed-off-by: shubham <[email protected]>
shubham14bajpai
force-pushed
the
vol-migrate
branch
from
27d9c91 to
5f5c9e3
Compare
mittachaitu
approved these changes
Jun 10, 2020
| } | ||
| if cvcObj.Status.Phase != cstor.CStorVolumeConfigPhaseBound { | ||
| klog.Infof("Waiting for cvc %s to become Bound, got: %s", v.PVName, cvcObj.Status.Phase) | ||
| time.Sleep(10 * time.Second) |
There was a problem hiding this comment.
This is sleep time is much high we can change it to 3 seconds
Signed-off-by: shubham <[email protected]>
9 tasks
Signed-off-by: shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham [email protected]
This PR adds support Cstor volume migration from external provisioner volume spec to CSI volume spec.
Example yaml:
Example logs: