Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(upgrade): add support for jiva-csi volume upgrades #89

Merged
merged 6 commits into from
Mar 30, 2021
Merged

feat(upgrade): add support for jiva-csi volume upgrades #89

merged 6 commits into from
Mar 30, 2021

Conversation

shubham14bajpai
Copy link
Contributor

@shubham14bajpai shubham14bajpai commented Jan 25, 2021 •
edited
Loading

Signed-off-by: shubham [email protected]

What this PR does:
This PR enables upgrades for jiva-csi volumes.

Locally tested with 3 replica volume, following are the job logs:

root@payes-master:~# k logs -f upgrade-volume-n59dg
I0323 13:38:51.481223       1 jiva_volume.go:65] Upgrading pvc-cc16fb25-f419-4967-8974-1d2b47acb953 to master-dev
I0323 13:38:55.243024       1 statefulset.go:77] patching statefulset pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-rep
I0323 13:38:56.386823       1 statefulset.go:109] rollout status: Waiting for statefulset spec update to be observed...
I0323 13:39:01.960340       1 statefulset.go:109] rollout status: waiting for statefulset rolling update to complete 0 pods at revision pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-rep-6cf6c9ccc7...
I0323 13:39:06.965733       1 statefulset.go:109] rollout status: Waiting for 1 pods to be ready...
I0323 13:39:11.970607       1 statefulset.go:109] rollout status: Waiting for 1 pods to be ready...
I0323 13:39:17.311933       1 statefulset.go:109] rollout status: Waiting for 1 pods to be ready...
I0323 13:39:22.321675       1 statefulset.go:109] rollout status: Waiting for 1 pods to be ready...
I0323 13:39:27.803367       1 statefulset.go:109] rollout status: Waiting for 1 pods to be ready...
I0323 13:39:32.813279       1 statefulset.go:109] rollout status: statefulset rolling update complete 1 pods at revision pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-rep-6cf6c9ccc7...
I0323 13:39:32.813329       1 statefulset.go:116] statefulset pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-rep patched successfully
I0323 13:39:32.846497       1 deployment.go:78] patching deployment pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl
I0323 13:39:35.682617       1 deployment.go:115] rollout status: Waiting for deployment "pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl" rollout to finish: 0 out of 1 new replicas have been updated...
I0323 13:39:40.762609       1 deployment.go:115] rollout status: Waiting for deployment "pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl" rollout to finish: 0 out of 1 new replicas have been updated...
I0323 13:39:46.122598       1 deployment.go:115] rollout status: Waiting for deployment "pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl" rollout to finish: 0 out of 1 new replicas have been updated...
I0323 13:39:51.134473       1 deployment.go:115] rollout status: Waiting for deployment "pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl" rollout to finish: 0 out of 1 new replicas have been updated...
I0323 13:39:56.445406       1 deployment.go:115] rollout status: Waiting for deployment "pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl" rollout to finish: 0 of 1 updated replicas are available...
I0323 13:40:01.641410       1 deployment.go:115] rollout status: Waiting for deployment "pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl" rollout to finish: 0 of 1 updated replicas are available...
I0323 13:40:07.242471       1 deployment.go:115] rollout status: Waiting for deployment "pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl" rollout to finish: 0 of 1 updated replicas are available...
I0323 13:40:12.262838       1 deployment.go:115] rollout status: deployment "pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl" successfully rolled out
I0323 13:40:12.262896       1 deployment.go:122] deployment pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl patched successfully
I0323 13:40:12.262920       1 service.go:77] Patching service pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl-svc
I0323 13:40:12.305404       1 service.go:99] Service pvc-cc16fb25-f419-4967-8974-1d2b47acb953-jiva-ctrl-svc patched
I0323 13:40:12.305978       1 jivavolume.go:76] patching jv pvc-cc16fb25-f419-4967-8974-1d2b47acb953
I0323 13:40:12.356471       1 jivavolume.go:96] jv pvc-cc16fb25-f419-4967-8974-1d2b47acb953 patched
I0323 13:40:12.506156       1 jiva_volume.go:383] Verifying the reconciliation of version for pvc-cc16fb25-f419-4967-8974-1d2b47acb953
I0323 13:40:22.551463       1 jiva_volume.go:76] Successfully upgraded pvc-cc16fb25-f419-4967-8974-1d2b47acb953 to master-dev

Which issue(s) this PR fixes:
Fixes #87

Special notes for your reviewer:

Checklist

  • PR messages has document related information
  • Labelled this PR & related issue with documentation tag
  • PR messages has breaking changes related information
  • PR messages has upgrade related information
  • Labelled this PR & related issue with requires-upgrade tag
  • Tests updated

@shubham14bajpai shubham14bajpai force-pushed the jiva branch 3 times, most recently from 9bcd652 to d376e8b Compare March 10, 2021 06:22
@shubham14bajpai shubham14bajpai marked this pull request as ready for review March 10, 2021 06:22
prateekpandey14
prateekpandey14 reviewed Mar 30, 2021
View reviewed changes
cmd/upgrade/executor/jiva_volume.go Outdated Show resolved Hide resolved
cmd/upgrade/executor/jiva_volume.go Outdated Show resolved Hide resolved
cmd/upgrade/executor/resource.go Outdated Show resolved Hide resolved
examples/upgrade/jiva-volume.yaml Outdated Show resolved Hide resolved
examples/upgrade/jiva-volume.yaml Outdated Show resolved Hide resolved
pkg/migrate/cstor/cspc_generator.go Show resolved Hide resolved
pkg/upgrade/upgrader/upgradetask.go Outdated Show resolved Hide resolved
prateekpandey14
prateekpandey14 reviewed Mar 30, 2021
View reviewed changes
pkg/upgrade/patch/jivavolume.go Outdated Show resolved Hide resolved
pkg/upgrade/patch/jivavolume.go Outdated Show resolved Hide resolved
prateekpandey14
prateekpandey14 reviewed Mar 30, 2021
View reviewed changes
pkg/upgrade/patch/jivavolume.go
"context"
"strings"

// clientset "github.com/openebs/api/v2/pkg/client/clientset/versioned"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove

@prateekpandey14 prateekpandey14 merged commit 9ab1d19 into openebs-archive:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekpandey14 prateekpandey14 prateekpandey14 left review comments

@niladrih niladrih Awaiting requested review from niladrih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for jiva csi volume upgrades
2 participants
@shubham14bajpai @prateekpandey14