refact(upgrade): add control plane checks in pre-upgrade #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
mittachaitu
reviewed
May 23, 2020
| @@ -60,7 +61,11 @@ func NewCSPCPatch(opts ...CSPCPatchOptions) *CSPCPatch { | |||
|
|
|||
| // PreUpgrade ... | |||
| func (obj *CSPCPatch) PreUpgrade() error { | |||
| err := obj.CSPC.PreChecks(obj.From, obj.To) | |||
| err := isOperatorUpgraded("cspc-operator", obj.Namespace, obj.To, obj.KubeClientset) | |||
There was a problem hiding this comment.
Should it go into precheck right(because it is mostly like check before upgrade)?
There was a problem hiding this comment.
Precheck is for a specific CR, it does not checks for any other resource. Preupgrade is for a volume or pool as a whole(means openebs CRs + deploy + service), so it makes more sense to have it in preupgrade.
mittachaitu
approved these changes
May 28, 2020
| return fmt.Errorf("operator pod missing for %s", componentName) | ||
| } | ||
| for _, pod := range operatorPods.Items { | ||
| if pod.Labels["openebs.io/version"] != toVersion { |
There was a problem hiding this comment.
nit: We can move openebs.io/version to some global constant.
There was a problem hiding this comment.
Sure. Will take this in separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham [email protected]
This PR adds pre-upgrade checks for control plane operators.