Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : Added PR and Issue template #54

Merged
merged 2 commits into from
Oct 4, 2020
Merged

chore : Added PR and Issue template #54

merged 2 commits into from
Oct 4, 2020

Conversation

Hard-Coder05
Copy link
Contributor

This PR solves the issue: openebs/openebs#3144

Copy link
Contributor

@shubham14bajpai shubham14bajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave a few comments

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature-request.md Outdated Show resolved Hide resolved
Copy link
Contributor

@shubham14bajpai shubham14bajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hard-Coder05
Copy link
Contributor Author

@shubham14bajpai @prateekpandey14 As the changes are aproved Please merge the PR!

Copy link

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prateekpandey14
Copy link

Thank you @Hard-Coder05 for this PR. You can sign up for Hacktoberfest swag from MayaData by entering details here: https://github.com/mayadata-io/swag/issues/new/choose

@Hard-Coder05
Copy link
Contributor Author

@prateekpandey14 I have a doubt! The contribution detail form had no option for T-Shirt size btw!

@prateekpandey14
Copy link

ahh , added the size option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants