Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(migrate): add travis sanity test #29

Merged
merged 5 commits into from
Aug 5, 2020
Merged

chore(migrate): add travis sanity test #29

merged 5 commits into from
Aug 5, 2020

Conversation

shubham14bajpai
Copy link
Contributor

@shubham14bajpai shubham14bajpai commented Jul 24, 2020 •
edited
Loading

Signed-off-by: shubham [email protected]

This PR

  • adds sanity tests to the travis-ci using stages to have parallel unit, upgrade and migrate sanity tests.
  • fixes the flaky unit test by replacing package reflect with go-cmp.
  • updates build script to use travis branch or tag the current version.
  • update deploy-images universal push script.

Manual tests covered locally:

  • exported TRAVIS_BRANCH as master, v1.12.x and executed sanity test for both upgrade and migrate.
  • exported TRAVIS_TAG as v1.12.0-RC1, v1.12.0 and executed sanity test for both upgrade and migrate.

@shubham14bajpai
this commit adds job logs to travis and fixes
dd1c22d 
the flaky unit test by replacing reflect with go-cmp

Signed-off-by: shubham <[email protected]>
@shubham14bajpai
add stages to travis for different tests
67f21dd 
Signed-off-by: shubham <[email protected]>
@shubham14bajpai shubham14bajpai linked an issue Jul 28, 2020 that may be closed by this pull request
Add upgrade related test cases #14
Closed
4 tasks
@shubham14bajpai
This commit
4610c97 
- adds sanity test for upgrade
- update build script to use travis tag or branch as version
- use universal push script

Signed-off-by: shubham <[email protected]>
kmova
kmova approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@kmova kmova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!!

@kmova kmova merged commit fee8f18 into openebs-archive:master Aug 5, 2020
prateekpandey14
prateekpandey14 reviewed Aug 5, 2020
View reviewed changes
Copy link

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shubham14bajpai shubham14bajpai deleted the migrate-ci branch August 19, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekpandey14 prateekpandey14 prateekpandey14 left review comments

@kmova kmova kmova approved these changes

Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add upgrade related test cases
3 participants
@shubham14bajpai @prateekpandey14 @kmova