feat(migrate): add support to rename spc while migrating to cspc

[shubham14bajpai]

Signed-off-by: shubham [email protected]

This PR adds the flag cspc-name to rename the spc while migrating it to cspc. It also adds checks to prevent deletion of a spc if already a cspc exists with the same name as spc.

This PR fixes this Issue: openebs/openebs#3074

Sample job yaml:

---
apiVersion: batch/v1
kind: Job
metadata:
  name: migrate-spc-sparse-claim-auto
  namespace: openebs
spec:
  backoffLimit: 0
  template:
    spec:
      #VERIFY the value of serviceAccountName is pointing to service account
      # created within openebs namespace. Use the non-default account.
      # by running `kubectl get sa -n <openebs-namespace>`
      serviceAccountName: openebs-maya-operator
      containers:
      - name:  migrate
        args:
        - "cstor-spc"
        # name of the spc that is to be migrated
        - "--spc-name=sparse-claim"
        # optional flag to rename the spc to a specific name
        - "--cspc-name=sparse-claim-migrated"

        #Following are optional parameters
        #Log Level
        - "--v=4"
        #DO NOT CHANGE BELOW PARAMETERS
        env:
        - name: OPENEBS_NAMESPACE
          valueFrom:
            fieldRef:
              fieldPath: metadata.namespace
        tty: true
        image: openebs/migrate-amd64:ci
      restartPolicy: Never
---

[mittachaitu]

changes are good

[mittachaitu]

provided comments please take a look

[mittachaitu]

Now I have another concern with configuration if the user does in below manner:

• The user has multiple SPCs in his setup and launched a job(By applying job YAML by setting cspc-name argument) to migrate to CSPC(Consider pool is successfully migrated).
• He reused the same Job YAML to migrate another SPC but now somehow he didn't change the cspc-name with this steps things will wrong(I can see job will update the blockdeviceclaim labels with cspc-name argument and return error).

[shubham14bajpai]

We can overcome this by adding old spc name on the cspc and verify that it isn't from another migrated spc.

[shubham14bajpai]

Done

[mittachaitu]

Still, this problem exists but now it will patch SPC and fail(Can we prevent updating SPC annotation itself?) @shubham14bajpai

[mittachaitu]

provided few comments PTAL

[mittachaitu]

Still, this problem exists but now it will patch SPC and fail(Can we prevent updating SPC annotation itself?) @shubham14bajpai

[mittachaitu]

changes are good

[mittachaitu]

nit: Instead of passing spcName as an argument we can make use of c.SPCObj.Name

[prateekpandey14]

lgtm