Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move spdk-rs to the mayastor repo #64

Open
tiagolobocastro opened this issue Oct 10, 2024 · 5 comments
Open

Move spdk-rs to the mayastor repo #64

tiagolobocastro opened this issue Oct 10, 2024 · 5 comments

Comments

@tiagolobocastro
Copy link
Contributor

tiagolobocastro commented Oct 10, 2024

Is your feature request related to a problem? Please describe.
Move spdk-rs repo to the mayastor repo.
In practice only mayastor seems to really use this repo. Moving them together will simplify the management, especially considering that now the rust compiler environment etc is defined on this repo and therefore adds the extra burden of modifying this repo first, and then resync mayastor.
Also it's not uncommon to have more than 1 crates on the same repo, it might make cloning a little slower though, but that is something you don't do a lot anyway.

Describe alternatives you've considered
Leave as is.

Additional context
Not that there aren't good reasons to keep it separate, but it's not without the downside of tiresome resyncs time and time again...

@tiagolobocastro
Copy link
Contributor Author

Any comments here @dsharma-dc @dsharma-dc ?

@dsharma-dc
Copy link
Contributor

Can we also list down the reasons that justify the status-quo i.e. the reasons to keep it separate ? Clear modularity is one that I can see.
Is that a lot of churn to merge, worth doing with current code churn that's ongoing?

@tiagolobocastro
Copy link
Contributor Author

AFAIK it's just clear modularity.
I'm not sure how much churn it'd be, spdk-rs is already a submodule, so we'd have to replace it with the code.
Then everything should just work?

@dsharma-dc
Copy link
Contributor

Most likely yes, with the required minor changes to cargo toml etc. Maybe we'll have to also modify/merge github workflows.

@tiagolobocastro
Copy link
Contributor Author

Any comments here @dsharma-dc @dsharma-dc ?

oops I put Diwakar twice, one was meant for @dsavitskiy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants