-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move spdk-rs to the mayastor repo #64
Comments
Any comments here @dsharma-dc @dsharma-dc ? |
Can we also list down the reasons that justify the status-quo i.e. the reasons to keep it separate ? Clear modularity is one that I can see. |
AFAIK it's just clear modularity. |
Most likely yes, with the required minor changes to cargo toml etc. Maybe we'll have to also modify/merge github workflows. |
oops I put Diwakar twice, one was meant for @dsavitskiy |
Is your feature request related to a problem? Please describe.
Move spdk-rs repo to the mayastor repo.
In practice only mayastor seems to really use this repo. Moving them together will simplify the management, especially considering that now the rust compiler environment etc is defined on this repo and therefore adds the extra burden of modifying this repo first, and then resync mayastor.
Also it's not uncommon to have more than 1 crates on the same repo, it might make cloning a little slower though, but that is something you don't do a lot anyway.
Describe alternatives you've considered
Leave as is.
Additional context
Not that there aren't good reasons to keep it separate, but it's not without the downside of tiresome resyncs time and time again...
The text was updated successfully, but these errors were encountered: