Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata write is not atomic #20

Open
laurivosandi opened this issue Dec 26, 2022 · 1 comment
Open

Metadata write is not atomic #20

laurivosandi opened this issue Dec 26, 2022 · 1 comment

Comments

@laurivosandi
Copy link
Contributor

The write_text function used to write config file is not atomic

https://stackoverflow.com/questions/73883435/is-python-3-path-write-text-from-pathlib-atomic

@semekh
Copy link
Collaborator

semekh commented Dec 28, 2022

Thanks for pointing that out. I'm aware that some of the actions are non-atomic and they might cause trouble but since those actions are infrequent, I expect them to barely matter. Also, even if things go wrong, the corruption is not FATAL, and should be fairly easy to fix.
Those are the reasons I haven't spent time on fixing it yet. That said, PRs are welcome as long they keep it simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants