You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please note that if you were using the OPENEBS_NAMESPACE env value other than `openebs` (default value) in which lvm-localpv CR's are created, don't forget to update that value in lvm-operator yaml file under OPENEBS_NAMESPACE env.
)
then again looking at patch 333, this was reverted. The revert needs some more work as of now. Especially this line needs to be changed too (ref:
) and the test suite needs to be bumped to use LVM_NAMESPACE
Now before I proceed to making this small changes and raise a patch, I wanted to understand which one out of OPENEBS_NAMESPACE and LVM_NAMESPACE will be used going forward? Happy to send a patch to fix this but this requires discussion first given this is a breaking change.
Environment:
LVM Driver version: It's 1.6.2 for me and I'm building an image by checking 1.6.2 tag.
Kubernetes version (use kubectl version):
Kubernetes installer & version: 1.30 k3s cluster
Cloud provider or hardware configuration: None (it's a Ubuntu instance running on AWS)
OS (e.g. from /etc/os-release): Ubuntu 24.04 LTS it is.
The text was updated successfully, but these errors were encountered:
#333 (as mentioned in the patch template that this is not compatible) I wanted to understand what is the correct one?
Looking at the current state of the repo gives me two indication, first that you want to move to OPENEBS_NAMESPACE (ref:
lvm-localpv/legacy-upgrade/README.md
Line 26 in 45e0fbd
then again looking at patch 333, this was reverted. The revert needs some more work as of now. Especially this line needs to be changed too (ref:
lvm-localpv/pkg/lvm/volume.go
Line 38 in 45e0fbd
Now before I proceed to making this small changes and raise a patch, I wanted to understand which one out of
OPENEBS_NAMESPACE
andLVM_NAMESPACE
will be used going forward? Happy to send a patch to fix this but this requires discussion first given this is a breaking change.Environment:
kubectl version
):/etc/os-release
): Ubuntu 24.04 LTS it is.The text was updated successfully, but these errors were encountered: