Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace rename breaks the helm chart and daemonsets #336

Open
kranurag7 opened this issue Sep 23, 2024 · 1 comment
Open

namespace rename breaks the helm chart and daemonsets #336

kranurag7 opened this issue Sep 23, 2024 · 1 comment

Comments

@kranurag7
Copy link

#333 (as mentioned in the patch template that this is not compatible) I wanted to understand what is the correct one?

Looking at the current state of the repo gives me two indication, first that you want to move to OPENEBS_NAMESPACE (ref:

Please note that if you were using the OPENEBS_NAMESPACE env value other than `openebs` (default value) in which lvm-localpv CR's are created, don't forget to update that value in lvm-operator yaml file under OPENEBS_NAMESPACE env.
)

then again looking at patch 333, this was reverted. The revert needs some more work as of now. Especially this line needs to be changed too (ref:

LvmNamespaceKey string = "OPENEBS_NAMESPACE"
) and the test suite needs to be bumped to use LVM_NAMESPACE

Now before I proceed to making this small changes and raise a patch, I wanted to understand which one out of OPENEBS_NAMESPACE and LVM_NAMESPACE will be used going forward? Happy to send a patch to fix this but this requires discussion first given this is a breaking change.

Environment:

  • LVM Driver version: It's 1.6.2 for me and I'm building an image by checking 1.6.2 tag.
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version: 1.30 k3s cluster
  • Cloud provider or hardware configuration: None (it's a Ubuntu instance running on AWS)
  • OS (e.g. from /etc/os-release): Ubuntu 24.04 LTS it is.
@tiagolobocastro
Copy link

Has this been resolved now? CC @niladrih @abhilashshetty04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants