chore(build): merge jiva-csi and jiva-operator repos #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
shubham14bajpai
requested review from
payes,
utkarshmani1997 and
prateekpandey14
Signed-off-by: shubham <[email protected]>
utkarshmani1997
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
@shubham14bajpai this LGTM, left a minor comment also can you add the ci tests in travis?
| endif | ||
| endif | ||
| export BASEIMAGE | ||
|
|
There was a problem hiding this comment.
Are we not going to support arm builds, or has it been handled elsewhere
There was a problem hiding this comment.
We will be building multi-arch builds using docker buildx github action. Will take that in separate PR.
Signed-off-by: shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham [email protected]
This PR merges the jiva-operator and jiva-csi repos together. By the merging, the two repos the dependency management would be reduced and the tests can be run in a more effective way.
Github action build: https://github.com/shubham14bajpai/jiva-operator/actions/runs/514739252
Note: The travis file will be removed after the multi-arch builds are enabled from github actions