Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PV Deletion protection finalizer #145

Open
celiawa opened this issue Sep 8, 2022 · 0 comments
Open

Support PV Deletion protection finalizer #145

celiawa opened this issue Sep 8, 2022 · 0 comments

Comments

@celiawa
Copy link

celiawa commented Sep 8, 2022

Describe the problem/challenge you have

Current there is a k8s bug:
If delete PV prior to deleting PVC, then the Reclaim policy is not exercised. As a result of this behavior, the associated storage asset in the external infrastructure is not removed.
For openebs nfs provisioner, that means the backend kinds of stuff (PV, PVC, deployment and service) are all left behind.

A feature gate HonorPVReclaimPolicy was added in kubernetes 1.23 to resolve such issue, refer to the KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2644-honor-pv-reclaim-policy

sig-storage-lib has already changed to support PV Deletion protection finalizer
kubernetes-sigs/sig-storage-lib-external-provisioner#117

Hope openebs can support this KEP.

Describe the solution you'd like

I think setting AddFinalizer to true when instantiating the nfs provisioner controller and upgrading the sig-storage library from v7 to v8 should be fine.
https://github.com/openebs/dynamic-nfs-provisioner/blob/1f414468b8c53b974c5dddbe02357a6ceb97d3b9/provisioner/controller.go#L70
image

Environment:

  • OpenEBS version (use kubectl get po -n openebs --show-labels): v0.9.0
  • Kubernetes version (use kubectl version): v1.23.6.

Vote on this issue!

This is an invitation to the OpenEBS community to vote on issues.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant