Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Double quote is unsupported #874

Closed
nkavian opened this issue Dec 2, 2020 · 3 comments
Closed

Double quote is unsupported #874

nkavian opened this issue Dec 2, 2020 · 3 comments

Comments

@nkavian
Copy link

nkavian commented Dec 2, 2020

When trying this command SELECT * FROM objects WHERE _object="Event" LIMIT 4; I get Objects: no response;

But when trying SELECT * FROM objects WHERE _object='Event' LIMIT 4;, it works fine.

If double quotes are not supported, the error message should match accordingly.

@dai-chen
Copy link
Member

dai-chen commented Dec 8, 2020

@nkavian Thanks for reporting the issue! We don't support double quotes in legacy engine. In new SQL engine, double quoted text is treated as identifier: https://github.com/opendistro-for-elasticsearch/sql/blob/develop/docs/user/general/identifiers.rst#delimited-identifiers.

We may support MySQL-like ANSI_MODE so you can configure if double quotes are for literal or identifier. Need to evaluate this.

@dai-chen dai-chen added enhancement New feature or request SQL labels Dec 8, 2020
@nkavian
Copy link
Author

nkavian commented Dec 9, 2020

Understood, it's okay if double quotes are not supported. I'm hoping that the error message could be more descriptive. Also, when I tried searching the documentation for double quotes, I didn't find anything that could help me understand what kind of quotes were supported. So my first experience using this plugin was difficult. Thanks.

@dai-chen
Copy link
Member

Understood, it's okay if double quotes are not supported. I'm hoping that the error message could be more descriptive. Also, when I tried searching the documentation for double quotes, I didn't find anything that could help me understand what kind of quotes were supported. So my first experience using this plugin was difficult. Thanks.

@nkavian Thanks for your feedback! We've improved the error message for Run/Explain in Workbench here: #872. Closing this issue. Feel free to reopen if needed. Thanks!

@dai-chen dai-chen added Workbench and removed enhancement New feature or request labels Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants