Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix new syntax check for LEFT JOIN on nested field and metadata field #191

Closed
dai-chen opened this issue Sep 23, 2019 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@dai-chen
Copy link
Member

Currently ON clause is required for all OUTER JOIN. However it's supposed to be missing in the case of LEFT JOIN on nested field. Need to figure out if we can handle this in grammar file. Otherwise, we have to make ON clause optional and verify in semantic analyzer.

@dai-chen dai-chen added the bug Something isn't working label Sep 23, 2019
@dai-chen dai-chen self-assigned this Sep 23, 2019
@dai-chen dai-chen changed the title Fix syntax check for LEFT JOIN on nested field Fix new syntax check for LEFT JOIN on nested field and other missing cases Sep 25, 2019
@dai-chen
Copy link
Member Author

I found another missing cases which new ANTLR parser should pass the syntax check for it. In #192, user should be able to use metadata field (mostly generated by log shipper like logstash), need to modify the grammar for this case too.

@dai-chen
Copy link
Member Author

For LEFT JOIN issue, I was thinking rely on DOT ID (to decide if ON should be required or not in grammar. But it seems more complicated than I thought like this case: FROM index LEFT JOIN e.projects p, e.comments c. So I think I'd better make our grammar straightforward and add more check in upcoming semantic analyzer.

@dai-chen dai-chen changed the title Fix new syntax check for LEFT JOIN on nested field and other missing cases Fix new syntax check for LEFT JOIN on nested field and metadata field Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant