From cb1cf36d321f434fafa82a8e4a8030bd49f92c66 Mon Sep 17 00:00:00 2001 From: Kiran Dintakurthi Date: Tue, 9 Apr 2019 20:55:37 +0000 Subject: [PATCH 1/9] Setting the tmpdir for tests --- .../reader/MasterEventMetricsSnapshotTests.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/reader/MasterEventMetricsSnapshotTests.java b/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/reader/MasterEventMetricsSnapshotTests.java index 71a7c6c8..c425f3e6 100644 --- a/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/reader/MasterEventMetricsSnapshotTests.java +++ b/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/reader/MasterEventMetricsSnapshotTests.java @@ -38,6 +38,7 @@ public class MasterEventMetricsSnapshotTests { @Before public void setup() throws Exception { + System.setProperty("java.io.tmpdir", "/tmp"); conn = DriverManager.getConnection(DB_URL); } From 5a9b3f673bf5746417982a5949d7d2014cb2a241 Mon Sep 17 00:00:00 2001 From: Kiran Dintakurthi Date: Tue, 9 Apr 2019 20:58:16 +0000 Subject: [PATCH 2/9] Revert "Setting the tmpdir for tests" This reverts commit cb1cf36d321f434fafa82a8e4a8030bd49f92c66. --- .../reader/MasterEventMetricsSnapshotTests.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/reader/MasterEventMetricsSnapshotTests.java b/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/reader/MasterEventMetricsSnapshotTests.java index c425f3e6..71a7c6c8 100644 --- a/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/reader/MasterEventMetricsSnapshotTests.java +++ b/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/reader/MasterEventMetricsSnapshotTests.java @@ -38,7 +38,6 @@ public class MasterEventMetricsSnapshotTests { @Before public void setup() throws Exception { - System.setProperty("java.io.tmpdir", "/tmp"); conn = DriverManager.getConnection(DB_URL); } From 3148a3c32c16a307005501eac645226acc0254b3 Mon Sep 17 00:00:00 2001 From: Kiran Dintakurthi Date: Wed, 10 Apr 2019 20:55:28 +0000 Subject: [PATCH 3/9] 7.0.0 support --- build.gradle | 2 +- .../http_action/whoami/TransportWhoAmIAction.java | 14 ++++++-------- .../http_action/whoami/WhoAmIAction.java | 9 +-------- .../http_action/whoami/WhoAmIRequestBuilder.java | 2 +- ...PerformanceAnalyzerTransportRequestHandler.java | 5 ----- 5 files changed, 9 insertions(+), 23 deletions(-) diff --git a/build.gradle b/build.gradle index b25c86d1..33a9b149 100644 --- a/build.gradle +++ b/build.gradle @@ -16,7 +16,7 @@ buildscript { ext { - es_version = System.getProperty("es.version", "6.7.1") + es_version = System.getProperty("es.version", "7.0.0") } // This isn't applying from repositories.gradle so repeating it here repositories { diff --git a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/TransportWhoAmIAction.java b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/TransportWhoAmIAction.java index 57aea2ec..9bc277e8 100644 --- a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/TransportWhoAmIAction.java +++ b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/TransportWhoAmIAction.java @@ -20,25 +20,23 @@ import org.elasticsearch.action.ActionListener; import org.elasticsearch.action.support.ActionFilters; import org.elasticsearch.action.support.HandledTransportAction; -import org.elasticsearch.cluster.metadata.IndexNameExpressionResolver; import org.elasticsearch.common.inject.Inject; -import org.elasticsearch.common.settings.Settings; -import org.elasticsearch.threadpool.ThreadPool; import org.elasticsearch.transport.TransportService; import org.elasticsearch.indices.IndicesService; +import org.elasticsearch.tasks.Task; public class TransportWhoAmIAction extends HandledTransportAction { @Inject - public TransportWhoAmIAction(final Settings settings, final ThreadPool threadPool, - final TransportService transportService, final ActionFilters actionFilters, - final IndexNameExpressionResolver indexNameExpressionResolver, final IndicesService indicesService) { - super(settings, WhoAmIAction.NAME, threadPool, transportService, actionFilters, indexNameExpressionResolver, WhoAmIRequest::new); + public TransportWhoAmIAction(final TransportService transportService, + final ActionFilters actionFilters, + final IndicesService indicesService) { + super(WhoAmIAction.NAME, transportService, actionFilters, WhoAmIRequest::new); ESResources.INSTANCE.setIndicesService(indicesService); } @Override - protected void doExecute(WhoAmIRequest request, ActionListener listener) { + protected void doExecute(Task task, WhoAmIRequest request, ActionListener listener) { listener.onResponse(new WhoAmIResponse()); } } diff --git a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/WhoAmIAction.java b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/WhoAmIAction.java index a2294ff2..55751502 100644 --- a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/WhoAmIAction.java +++ b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/WhoAmIAction.java @@ -16,9 +16,8 @@ package com.amazon.opendistro.elasticsearch.performanceanalyzer.http_action.whoami; import org.elasticsearch.action.Action; -import org.elasticsearch.client.ElasticsearchClient; -public class WhoAmIAction extends Action { +public class WhoAmIAction extends Action { public static final WhoAmIAction INSTANCE = new WhoAmIAction(); public static final String NAME = "cluster:admin/performanceanalyzer/whoami"; @@ -27,14 +26,8 @@ protected WhoAmIAction() { super(NAME); } - @Override - public WhoAmIRequestBuilder newRequestBuilder(final ElasticsearchClient client) { - return new WhoAmIRequestBuilder(client, this); - } - @Override public WhoAmIResponse newResponse() { return new WhoAmIResponse(); } - } diff --git a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/WhoAmIRequestBuilder.java b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/WhoAmIRequestBuilder.java index e89bec88..89f72737 100644 --- a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/WhoAmIRequestBuilder.java +++ b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/http_action/whoami/WhoAmIRequestBuilder.java @@ -19,7 +19,7 @@ import org.elasticsearch.client.ClusterAdminClient; import org.elasticsearch.client.ElasticsearchClient; -public class WhoAmIRequestBuilder extends ActionRequestBuilder { +public class WhoAmIRequestBuilder extends ActionRequestBuilder { public WhoAmIRequestBuilder(final ClusterAdminClient client) { this(client, WhoAmIAction.INSTANCE); } diff --git a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/transport/PerformanceAnalyzerTransportRequestHandler.java b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/transport/PerformanceAnalyzerTransportRequestHandler.java index 8d88ab14..00826b07 100644 --- a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/transport/PerformanceAnalyzerTransportRequestHandler.java +++ b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/transport/PerformanceAnalyzerTransportRequestHandler.java @@ -79,9 +79,4 @@ private TransportChannel getShardBulkChannel(T request, TransportChannel channel return performanceanalyzerChannel; } - - @Override - public void messageReceived(T request, TransportChannel channel) throws Exception { - messageReceived(request, channel, null); - } } From e650361a3df2f6dc1dd71b0abcd22476e82b3f5b Mon Sep 17 00:00:00 2001 From: Kiran Dintakurthi Date: Wed, 8 May 2019 22:15:57 +0000 Subject: [PATCH 4/9] changes to 0.7.1 --- build.gradle | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/build.gradle b/build.gradle index 52614352..cd5a9040 100644 --- a/build.gradle +++ b/build.gradle @@ -16,7 +16,7 @@ buildscript { ext { - es_version = System.getProperty("es.version", "7.0.0") + es_version = System.getProperty("es.version", "7.0.1") } // This isn't applying from repositories.gradle so repeating it here repositories { @@ -146,7 +146,6 @@ dependencyLicenses.doFirst { integTestRunner { // add "-Dtests.security.manager=false" to VM options if you want to run integ tests in IntelliJ systemProperty 'tests.security.manager', 'false' - ifNoTests 'ignore' } bundlePlugin { From 6ce40aac66210939be8530c5dc030adbb2b04eaa Mon Sep 17 00:00:00 2001 From: Adithya Chandra Date: Wed, 5 Jun 2019 17:43:25 -0700 Subject: [PATCH 5/9] Add access logs to performance analyzer webservice --- .../performanceanalyzer/rest/QueryMetricsRequestHandler.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rest/QueryMetricsRequestHandler.java b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rest/QueryMetricsRequestHandler.java index f5dcd006..2a01380b 100644 --- a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rest/QueryMetricsRequestHandler.java +++ b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rest/QueryMetricsRequestHandler.java @@ -70,6 +70,7 @@ public QueryMetricsRequestHandler() { @Override public void handle(HttpExchange exchange) throws IOException { String requestMethod = exchange.getRequestMethod(); + LOG.info("{} {} {}", exchange.getRequestMethod(), exchange.getRemoteAddress(), exchange.getRequestURI()); ReaderMetricsProcessor mp = ReaderMetricsProcessor.getInstance(); if (mp == null) { sendResponse(exchange, From 11b382138d17154872df543c7d5eb4fe0a2ca0a2 Mon Sep 17 00:00:00 2001 From: Adithya Chandra Date: Mon, 10 Jun 2019 13:54:43 -0700 Subject: [PATCH 6/9] Fix release notes and opendistro version --- build.gradle | 2 +- release-notes | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index cd5a9040..2130a55f 100644 --- a/build.gradle +++ b/build.gradle @@ -34,7 +34,7 @@ plugins { } ext { - opendistroVersion = '0.9.0' + opendistroVersion = '1.0.0' isSnapshot = "true" == System.getProperty("build.snapshot", "true") } diff --git a/release-notes b/release-notes index e4969e53..19a421f6 100644 --- a/release-notes +++ b/release-notes @@ -1,3 +1,7 @@ +## Version 1.0.0 (Version compatible with elasticsearch 7.0.1) +## New Features +This is the release of the Open Distro Performance Analyzer that will work with elasticsearch 7.0.1 + ## Version 0.9.0 (Version compatible with elasticsearch 6.7.1) ## New Features This is the release of the Open Distro Performance Analyzer that will work with elasticsearch 6.7.1 From d08b3ecf904fb8d4d77f7c8f189b907ba61a8707 Mon Sep 17 00:00:00 2001 From: Balaji Kannan Date: Tue, 18 Jun 2019 19:08:16 -0700 Subject: [PATCH 7/9] Updated version to support ES-7.1.1 --- build.gradle | 4 ++-- gradle/wrapper/gradle-wrapper.properties | 2 +- release-notes | 4 ++++ 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/build.gradle b/build.gradle index 2130a55f..643f0956 100644 --- a/build.gradle +++ b/build.gradle @@ -16,7 +16,7 @@ buildscript { ext { - es_version = System.getProperty("es.version", "7.0.1") + es_version = System.getProperty("es.version", "7.1.1") } // This isn't applying from repositories.gradle so repeating it here repositories { @@ -34,7 +34,7 @@ plugins { } ext { - opendistroVersion = '1.0.0' + opendistroVersion = '1.1.0' isSnapshot = "true" == System.getProperty("build.snapshot", "true") } diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index 44e7c4d1..ea13fdfd 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,5 +1,5 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-bin.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-5.3.1-bin.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists diff --git a/release-notes b/release-notes index 19a421f6..9310b162 100644 --- a/release-notes +++ b/release-notes @@ -1,3 +1,7 @@ +## Version 1.1.0 (Version compatible with elasticsearch 7.1.1) +## New Features +This is the release of the Open Distro Performance Analyzer that will work with elasticsearch 7.1.1 + ## Version 1.0.0 (Version compatible with elasticsearch 7.0.1) ## New Features This is the release of the Open Distro Performance Analyzer that will work with elasticsearch 7.0.1 From 54583008379fae9aacf7d735ac6127016242245d Mon Sep 17 00:00:00 2001 From: Karthik Kumarguru Date: Wed, 24 Jul 2019 14:59:04 -0700 Subject: [PATCH 8/9] Update PerformanceAnalyzer to support ElasticSearch v7.2.0 --- build.gradle | 4 ++-- gradle/wrapper/gradle-wrapper.properties | 2 +- release-notes | 12 ++++++++++++ 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/build.gradle b/build.gradle index 990270cb..1f013563 100644 --- a/build.gradle +++ b/build.gradle @@ -16,7 +16,7 @@ buildscript { ext { - es_version = System.getProperty("es.version", "6.7.1") + es_version = System.getProperty("es.version", "7.2.0") } // This isn't applying from repositories.gradle so repeating it here repositories { @@ -34,7 +34,7 @@ plugins { } ext { - opendistroVersion = '0.9.0' + opendistroVersion = '1.2.0' isSnapshot = "true" == System.getProperty("build.snapshot", "true") } diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index 44e7c4d1..f4d7b2bf 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,5 +1,5 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-bin.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-bin.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists diff --git a/release-notes b/release-notes index e4969e53..185b86eb 100644 --- a/release-notes +++ b/release-notes @@ -1,3 +1,15 @@ +## Version 1.2.0 (Version compatible with elasticsearch 7.2.0) +## New Features +This is the release of the Open Distro Performance Analyzer that will work with elasticsearch 7.2.0 + +## Version 1.1.0 (Version compatible with elasticsearch 7.1.1) +## New Features +This is the release of the Open Distro Performance Analyzer that will work with elasticsearch 7.1.1 + +## Version 1.0.0 (Version compatible with elasticsearch 7.0.1) +## New Features +This is the release of the Open Distro Performance Analyzer that will work with elasticsearch 7.0.1 + ## Version 0.9.0 (Version compatible with elasticsearch 6.7.1) ## New Features This is the release of the Open Distro Performance Analyzer that will work with elasticsearch 6.7.1 From 30dc250853d92bdfb5cd96b794b8cc6ce3cbc23c Mon Sep 17 00:00:00 2001 From: Karthik Kumarguru Date: Wed, 24 Jul 2019 15:16:47 -0700 Subject: [PATCH 9/9] Fix checkstyle issues --- .../metrics/PerformanceAnalyzerMetrics.java | 5 +++-- .../rest/QueryMetricsRequestHandler.java | 14 +++++------- .../PerformanceAnalyzerMetricsTests.java | 22 +++++++++---------- 3 files changed, 20 insertions(+), 21 deletions(-) diff --git a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/metrics/PerformanceAnalyzerMetrics.java b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/metrics/PerformanceAnalyzerMetrics.java index 64d32951..adbba4af 100644 --- a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/metrics/PerformanceAnalyzerMetrics.java +++ b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/metrics/PerformanceAnalyzerMetrics.java @@ -81,7 +81,8 @@ public static String getCurrentTimeMetric() { } public static String generatePath(long startTime, String... keysPath) { - Path sDevShmLocationPath = Paths.get(sDevShmLocation).resolve(Paths.get(String.valueOf(PerformanceAnalyzerMetrics.getTimeInterval(startTime)), keysPath)); + Path sDevShmLocationPath = Paths.get(sDevShmLocation) + .resolve(Paths.get(String.valueOf(PerformanceAnalyzerMetrics.getTimeInterval(startTime)), keysPath)); return sDevShmLocationPath.toString(); } @@ -163,7 +164,7 @@ private static File writeToTmp(String keyPath, String value) throws Exception { } public static String getMetric(long startTime, String... keysPath) { - return getMetric(generatePath(startTime, keysPath)); + return getMetric(generatePath(startTime, keysPath)); } public static String getMetric(String keyPath) { diff --git a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rest/QueryMetricsRequestHandler.java b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rest/QueryMetricsRequestHandler.java index f4be281c..87972940 100644 --- a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rest/QueryMetricsRequestHandler.java +++ b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rest/QueryMetricsRequestHandler.java @@ -29,17 +29,16 @@ import java.util.Map; import java.util.Set; -import javax.net.ssl.HttpsURLConnection; - import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.message.ParameterizedMessage; import org.apache.logging.log4j.util.Supplier; - import org.jooq.Record; import org.jooq.Result; import com.amazon.opendistro.elasticsearch.performanceanalyzer.PerformanceAnalyzerApp; +import com.amazon.opendistro.elasticsearch.performanceanalyzer.collectors.StatExceptionCode; +import com.amazon.opendistro.elasticsearch.performanceanalyzer.collectors.StatsCollector; import com.amazon.opendistro.elasticsearch.performanceanalyzer.config.PluginSettings; import com.amazon.opendistro.elasticsearch.performanceanalyzer.metricsdb.MetricsDB; import com.amazon.opendistro.elasticsearch.performanceanalyzer.model.MetricAttributes; @@ -47,11 +46,9 @@ import com.amazon.opendistro.elasticsearch.performanceanalyzer.reader.ClusterLevelMetricsReader; import com.amazon.opendistro.elasticsearch.performanceanalyzer.reader.ReaderMetricsProcessor; import com.amazon.opendistro.elasticsearch.performanceanalyzer.util.JsonConverter; -import com.amazon.opendistro.elasticsearch.performanceanalyzer.collectors.StatsCollector; -import com.amazon.opendistro.elasticsearch.performanceanalyzer.collectors.StatExceptionCode; - import com.sun.net.httpserver.HttpExchange; import com.sun.net.httpserver.HttpHandler; +import javax.net.ssl.HttpsURLConnection; /** * Request handler that supports querying MetricsDB on every EC2 instance. @@ -188,9 +185,10 @@ public boolean validParams(HttpExchange exchange, List metricList, List< } } } - for (String agg : aggList) { + for (String agg : aggList) { if (!MetricsDB.AGG_VALUES.contains(agg)) { - sendResponse(exchange, String.format("{\"error\":\"%s is an invalid aggregation type.\"}", agg), HttpURLConnection.HTTP_BAD_REQUEST); + sendResponse(exchange, String.format("{\"error\":\"%s is an invalid aggregation type.\"}", agg), + HttpURLConnection.HTTP_BAD_REQUEST); return false; } } diff --git a/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/metrics/PerformanceAnalyzerMetricsTests.java b/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/metrics/PerformanceAnalyzerMetricsTests.java index da43e982..51a388fc 100644 --- a/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/metrics/PerformanceAnalyzerMetricsTests.java +++ b/src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/metrics/PerformanceAnalyzerMetricsTests.java @@ -15,25 +15,24 @@ package com.amazon.opendistro.elasticsearch.performanceanalyzer.metrics; -import com.amazon.opendistro.elasticsearch.performanceanalyzer.config.PluginSettings; -import static org.junit.Assert.assertEquals; -import org.junit.Test; import org.junit.Before; -import static org.mockito.Mockito.when; -import org.mockito.Mock; +import org.junit.Test; +import org.junit.runner.RunWith; import org.mockito.Mockito; import org.powermock.api.mockito.PowerMockito; +import org.powermock.core.classloader.annotations.PowerMockIgnore; import org.powermock.core.classloader.annotations.PrepareForTest; import org.powermock.core.classloader.annotations.SuppressStaticInitializationFor; -import org.powermock.core.classloader.annotations.PowerMockIgnore; -import org.junit.runner.RunWith; import org.powermock.modules.junit4.PowerMockRunner; -@PowerMockIgnore({ "org.apache.logging.log4j.*" }) +import com.amazon.opendistro.elasticsearch.performanceanalyzer.config.PluginSettings; +import static org.junit.Assert.assertEquals; + +@PowerMockIgnore({"org.apache.logging.log4j.*"}) @RunWith(PowerMockRunner.class) -@PrepareForTest({ PerformanceAnalyzerMetrics.class, PluginSettings.class }) -@SuppressStaticInitializationFor({ "PluginSettings" }) +@PrepareForTest({PerformanceAnalyzerMetrics.class, PluginSettings.class}) +@SuppressStaticInitializationFor({"PluginSettings"}) public class PerformanceAnalyzerMetricsTests { @Before @@ -59,7 +58,8 @@ public void testBasicMetric() { public void testGeneratePath() { long startTimeInMillis = 1553725339; String generatedPath = PerformanceAnalyzerMetrics.generatePath(startTimeInMillis, "dir1", "id", "dir2"); - String expectedPath = PerformanceAnalyzerMetrics.sDevShmLocation + "/" + String.valueOf(PerformanceAnalyzerMetrics.getTimeInterval(startTimeInMillis)) + "/dir1/id/dir2"; + String expectedPath = PerformanceAnalyzerMetrics.sDevShmLocation + + "/" + PerformanceAnalyzerMetrics.getTimeInterval(startTimeInMillis) + "/dir1/id/dir2"; assertEquals(expectedPath, generatedPath); } }