diff --git a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/actions/Action.java b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/actions/Action.java index 1b4346ecf..d8ebda843 100644 --- a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/actions/Action.java +++ b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/actions/Action.java @@ -33,13 +33,6 @@ public interface Action { /** Time to wait since last recommendation, before suggesting this action again */ int coolOffPeriodInSeconds(); - /** - * Called when the action is invoked. - * - *

Specific implementation may include executing the action, or invoking downstream APIs - */ - void execute(); - /** Returns a list of Elasticsearch nodes impacted by this action. */ List impactedNodes(); diff --git a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/actions/ModifyQueueCapacityAction.java b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/actions/ModifyQueueCapacityAction.java index 38a960e99..bf5cf5965 100644 --- a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/actions/ModifyQueueCapacityAction.java +++ b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/actions/ModifyQueueCapacityAction.java @@ -81,13 +81,6 @@ public Map impact() { return Collections.singletonMap(esNode, impactVector); } - @Override - public void execute() { - // Making this a no-op for now - // TODO: Modify based on downstream agent API calls - assert true; - } - @Override public String summary() { if (!isActionable()) { diff --git a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/deciders/Publisher.java b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/deciders/Publisher.java index 126769447..8250d5919 100644 --- a/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/deciders/Publisher.java +++ b/src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/decisionmaker/deciders/Publisher.java @@ -48,8 +48,6 @@ public EmptyFlowUnit operate() { Decision decision = collator.getFlowUnits().get(0); for (Action action : decision.getActions()) { -// LOG.info("Executing action: [{}]", action.name()); -// action.execute(); for (ActionListener listener: actionListeners) { listener.actionPublished(action); }