From fa6e4b9365eaacc0bf1e27d55d4cc3edd3596bdd Mon Sep 17 00:00:00 2001 From: Yizhe Liu Date: Thu, 28 May 2020 16:41:20 -0700 Subject: [PATCH 1/2] Fix issue where live chart height is only partial of window in fullscreen mode. Issue: #186 --- public/pages/Dashboard/Components/AnomaliesLiveChart.tsx | 7 +++++-- public/pages/Dashboard/index.scss | 4 ++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/public/pages/Dashboard/Components/AnomaliesLiveChart.tsx b/public/pages/Dashboard/Components/AnomaliesLiveChart.tsx index cd3ee318..0fca23d7 100644 --- a/public/pages/Dashboard/Components/AnomaliesLiveChart.tsx +++ b/public/pages/Dashboard/Components/AnomaliesLiveChart.tsx @@ -109,7 +109,10 @@ export const AnomaliesLiveChart = (props: AnomaliesLiveChartProps) => { true ); } catch (err) { - console.log('Error getting latest anomaly results - index may not exist yet', err); + console.log( + 'Error getting latest anomaly results - index may not exist yet', + err + ); setIsLoadingAnomalies(false); } @@ -236,7 +239,7 @@ export const AnomaliesLiveChart = (props: AnomaliesLiveChartProps) => { } actions={[fullScreenButton()]} - contentPanelClassName={isFullScreen ? 'full-screen' : undefined} + contentPanelClassName={isFullScreen ? 'dashboard-full-screen' : undefined} > {isLoadingAnomalies ? ( Date: Thu, 28 May 2020 17:26:01 -0700 Subject: [PATCH 2/2] Use correct fix as 'vh' doesn't work if page is too long --- public/pages/Dashboard/Components/AnomaliesLiveChart.tsx | 2 +- public/pages/Dashboard/index.scss | 9 --------- public/pages/main/Main.tsx | 2 +- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/public/pages/Dashboard/Components/AnomaliesLiveChart.tsx b/public/pages/Dashboard/Components/AnomaliesLiveChart.tsx index 0fca23d7..5f02181b 100644 --- a/public/pages/Dashboard/Components/AnomaliesLiveChart.tsx +++ b/public/pages/Dashboard/Components/AnomaliesLiveChart.tsx @@ -239,7 +239,7 @@ export const AnomaliesLiveChart = (props: AnomaliesLiveChartProps) => { } actions={[fullScreenButton()]} - contentPanelClassName={isFullScreen ? 'dashboard-full-screen' : undefined} + contentPanelClassName={isFullScreen ? 'full-screen' : undefined} > {isLoadingAnomalies ? ( +