This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adds maven publish task to notification #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,8 @@ | |||
|
|
|||
| apply plugin: 'java' | |||
| apply plugin: 'jacoco' | |||
| apply plugin: 'maven-publish' | |||
There was a problem hiding this comment.
basing off this Job-Scheduler PR this change doesn't have signing. Do we need to also add this?
jinsoor-amzn
previously approved these changes
Sep 25, 2019
| @@ -24,3 +27,78 @@ dependencies { | |||
| testImplementation "org.elasticsearch.test:framework:${es_version}" | |||
| testImplementation "org.easymock:easymock:4.0.1" | |||
| } | |||
|
|
|||
| shadowJar { | |||
There was a problem hiding this comment.
this may not work when you have ISM and alerting both depending on notification. I would suggest to repackage at ES plugin level to avoid JarHell
There was a problem hiding this comment.
Tested and relocation/repackaging seems to happen during publish and not build. Alerting/ISM using notification should be fine for now, but we do need a long term solution for our collective plugins dependencies. Thanks for the help!
zengyan-amazon
approved these changes
Oct 10, 2019
jinsoor-amzn
approved these changes
Oct 11, 2019
dbbaughe
added a commit
that referenced
this pull request
Jan 16, 2020
dbbaughe
added a commit
that referenced
this pull request
Jan 16, 2020
dbbaughe
added a commit
that referenced
this pull request
Jan 16, 2020
dbbaughe
added a commit
that referenced
this pull request
Jan 16, 2020
dbbaughe
added a commit
that referenced
this pull request
Feb 20, 2020
tlfeng
pushed a commit
that referenced
this pull request
Feb 6, 2021
* Adds maven publish task to notification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds maven publish task to notification
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.