Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Clarify the monitor creation text for visual editor #33

Closed
elfisher opened this issue Apr 10, 2019 · 6 comments
Closed

Clarify the monitor creation text for visual editor #33

elfisher opened this issue Apr 10, 2019 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@elfisher
Copy link
Contributor

Currently the text follows this pattern Match the following condition WHEN sum() OF select a field OVER all documents FOR THE LAST 1 hour(s)

This reads like a trigger but it for a monitor. We can revamp the text for clarity.

@elfisher elfisher added the bug Something isn't working label Apr 10, 2019
@stevensideyliu
Copy link
Contributor

Instead of Match the following condition we should replace to text with Create a monitor with the following condition WHEN sum() OF select a field OVER all documents FOR THE LAST 1 hour(s)

@elfisher
Copy link
Contributor Author

@stevensideyliu let's remove the condition word altogether. Maybe we can co Create a monitor for sum() of select a field OVER all documents FOR THE LAST 1?

@elfisher
Copy link
Contributor Author

@aetter have any thoughts on this?

@stevensideyliu stevensideyliu pinned this issue Apr 12, 2019
@aetter
Copy link
Contributor

aetter commented Apr 12, 2019

Sure, maybe Check for? As in, Check for WHEN count() OVER all documents FOR THE LAST 1 hour(s)?

I'm also fine with Check, Check for the following, Create a monitor for.

@elfisher
Copy link
Contributor Author

let's go with Create a monitor for sum() of select a field OVER all documents FOR THE LAST 1. @mihirsoni and @stevensideyliu does that sound good?

@mihirsoni mihirsoni unpinned this issue Apr 12, 2019
@mihirsoni
Copy link
Contributor

@elfisher sounds good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants