Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better sanity checks on devices input #11

Closed
samilliken opened this issue Jun 7, 2012 · 1 comment
Closed

Better sanity checks on devices input #11

samilliken opened this issue Jun 7, 2012 · 1 comment
Assignees
@wilpig
Labels
enhancement
Milestone
1.5 Release

Comments

@samilliken
Copy link
Member

The devices.php page will still allow you to enter a device at position 0. At a minimum, that needs to be checked to ensure that it is greater than 0, and less than (CabinetHeight - DeviceHeight + 1). Ideally, it would make an AJAX call for a sanity check on the position to ensure that it doesn't overlap another device. Possibly even show a help text with valid choices.
@ghost ghost assigned wilpig Jun 7, 2012
wilpig added a commit that referenced this issue Jul 5, 2012
@wilpig
Set 1 as the minimum value for rack position. Also added in loop to s…
734c585 
…earch for 0 height devices in rack view. #11
wilpig added a commit that referenced this issue Jul 17, 2012
@wilpig
Moved and renamed json.php to be uniform with the other script files.…
6087d83 
… New json results file for cabinet usage part of #11
wilpig added a commit that referenced this issue Jul 19, 2012
@wilpig
Added rack location picker to devices screen. Continuation of #11
f8e0631
wilpig added a commit that referenced this issue Jul 19, 2012
@wilpig
Added device slot picker to the rack request form. part of #11
5b4091b
wilpig added a commit that referenced this issue Jul 25, 2012
@wilpig
More data validation work toward #11
ae677c3
wilpig added a commit that referenced this issue Aug 8, 2012
@wilpig
More work towards data validation this time focusing on chassis devices
39910e4 
#11
wilpig added a commit that referenced this issue Aug 8, 2012
@wilpig
More data validation on chassis devices #11
88e0917
wilpig added a commit that referenced this issue Aug 24, 2012
@wilpig
Added data validation to cabinets.php part of #11
b1be443
@samilliken
Copy link
Member Author

Done

wilpig pushed a commit that referenced this issue Jul 27, 2015
@MorinPierre
Merge pull request #11 from samilliken/pue-test
564d573
@Negatifff Negatifff mentioned this issue Jul 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilpig wilpig

Labels
enhancement
Projects
None yet
Milestone
1.5 Release
Development

No branches or pull requests
2 participants
@wilpig @samilliken