Denote 23.03 fac_Country's countryCode as countryCode2 #1399
pawsey-kbuckley
started this conversation in
Ideas
Replies: 2 comments
-
Thought I'd try and link to the one to the issue to which it pertains: #1382 |
Beta Was this translation helpful? Give feedback.
0 replies
-
I don't really see any value in this as it is nothing other than a lookup table for a select list within the UI. Other than pedantry, there is no value served. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Just saw that part of the 23.03 (GPDR) work introduces a Country table into the DB.
Was thinking that, given that you are scraping ISO 3116 data, you might denote the
fact that you are using the ISO-3166 alpha2 data there, by using
countryCode2
,just in case (tm) you ever come to store the 3-char codes in the table as well.
Alternatively, if you are using the FIPS code, as opposed to ISO-3166 alpha2, then
maybe denote that provenance in some way, say
countryCodeFips
?Just a bit of "future-proofing" I guess.
Beta Was this translation helpful? Give feedback.
All reactions